The following document contains the results of Checkstyle. 
| Rules | Violations | Severity |
|---|---|---|
| FileLength | 0 |  Error |
| NewlineAtEndOfFile | 3 | Error |
| AbstractClassName | 1 | Error |
| AnnotationUseStyle | 0 | Error |
| AnonInnerLength | 5 | Error |
| ArrayTrailingComma | 5 | Error |
| ArrayTypeStyle | 4 | Error |
| AvoidInlineConditionals | 1 | Error |
| AvoidStaticImport | 0 | Error |
| ClassDataAbstractionCoupling | 4 | Error |
| ClassFanOutComplexity | 2 | Error |
| ClassTypeParameterName | 0 | Error |
| ConstantName | 2 | Error |
| CovariantEquals | 3 | Error |
| DeclarationOrder | 104 | Error |
| DefaultComesLast | 0 | Error |
| DescendantToken | 0 | Error |
| DesignForExtension | 166 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyBlock | 11 | Error |
| EmptyForInitializerPad | 0 | Error |
| EmptyForIteratorPad | 0 | Error |
| EmptyStatement | 0 | Error |
| EqualsAvoidNull | 9 | Error |
| EqualsHashCode | 2 | Error |
| ExecutableStatementCount | 13 | Error |
| ExplicitInitialization | 3 | Error |
| FallThrough | 0 | Error |
| FinalClass | 0 | Error |
| FinalLocalVariable | 182 | Error |
| FinalParameters | 223 | Error |
| GenericWhitespace | 0 | Error |
| HiddenField | 59 | Error |
| HideUtilityClassConstructor | 1 | Error |
| IllegalCatch | 4 | Error |
| IllegalImport | 0 | Error |
| IllegalInstantiation | 0 | Error |
| IllegalThrows | 0 | Error |
| IllegalTokenText | 0 | Error |
| IllegalType | 10 | Error |
| Indentation | 63 | Error |
| InnerAssignment | 0 | Error |
| InterfaceIsType | 0 | Error |
| JUnitTestCase | 0 | Error |
| JavaNCSS | 5 | Error |
| LeftCurly | 4 | Error |
| LocalFinalVariableName | 8 | Error |
| LocalVariableName | 31 | Error |
| MemberName | 22 | Error |
| MethodName | 0 | Error |
| MethodParamPad | 2 | Error |
| MethodTypeParameterName | 0 | Error |
| MissingCtor | 1 | Error |
| MissingDeprecated | 0 | Error |
| MissingOverride | 0 | Error |
| ModifierOrder | 3 | Error |
| MultipleStringLiterals | 27 | Error |
| MultipleVariableDeclarations | 0 | Error |
| MutableException | 0 | Error |
| NPathComplexity | 4 | Error |
| NeedBraces | 4 | Error |
| NoClone | 0 | Error |
| NoFinalizer | 0 | Error |
| NoWhitespaceBefore | 1 | Error |
| OperatorWrap | 1 | Error |
| OuterTypeNumber | 0 | Error |
| PackageAnnotation | 0 | Error |
| PackageDeclaration | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 16 | Error |
| ParameterNumber | 0 | Error |
| ParenPad | 4 | Error |
| RedundantImport | 2 | Error |
| RedundantModifier | 0 | Error |
| RedundantThrows | 1 | Error |
| RightCurly | 1 | Error |
| StaticVariableName | 0 | Error |
| SuperClone | 0 | Error |
| SuperFinalize | 0 | Error |
| SuppressWarnings | 0 | Error |
| ThrowsCount | 1 | Error |
| TodoComment | 0 | Error |
| TypeName | 0 | Error |
| TypecastParenPad | 0 | Error |
| UncommentedMain | 1 | Error |
| UpperEll | 0 | Error |
| VisibilityModifier | 33 | Error |
| WhitespaceAfter | 63 | Error |
| WhitespaceAround | 467 | Error |
| WriteTag | 5 | Error |
| MagicNumber | 186 | Error |
| UnusedImports | 4 | Error |
| AvoidStarImport | 2 | Error |
| AvoidNestedBlocks | 8 | Error |
| NoWhitespaceAfter | 1 | Error |
| BooleanExpressionComplexity | 0 | Error |
| CyclomaticComplexity | 9 | Error |
| MethodLength | 0 | Error |
| MissingSwitchDefault | 1 | Error |
| ModifiedControlVariable | 4 | Error |
| NestedTryDepth | 0 | Error |
| ParameterAssignment | 6 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| StringLiteralEquality | 0 | Error |
LineLength
| 6 | Error |
NestedIfDepth
| 5 | Error |
| ReturnCount | 7 | Error |
| Violation | Message | Line |
|---|---|---|
| Unused import - javax.swing.JFrame. | 27 |
| Unused import - javax.swing.JOptionPane. | 30 |
| The String "Option Pane" appears 2 times in the file. | 52 |
| Parameter e should be final. | 57 |
| Line is longer than 160 characters. | 70 |
| Violation | Message | Line |
|---|---|---|
| Unused import - java.awt.event.KeyEvent. | 34 |
| Unused import - java.awt.event.KeyListener. | 35 |
| Class Data Abstraction Coupling is 25 (max allowed is 7) classes [ActionListener, ArrayList, CSVTypeFileFilter, CSVTypeLog, Dimension, EntireGraphingPanel, File, FileInputStream, FileOutputStream, FreeEMSBin, FreeEMSByteLA, FreeEMSFileFilter, FreeEMSLAFileFilter, GraphMenu, JFileChooser, OptionFrameV2, PlayBarPanel, Properties, PropertiesPane, Runnable, java.awt.BorderLayout, javax.swing.JMenu, javax.swing.JMenuBar, javax.swing.JMenuItem, javax.swing.JPanel]. | 67 |
| Class Fan-Out Complexity is 35 (max allowed is 20). | 67 |
| Executable statement count is 45 (max allowed is 30). | 74 |
| NCSS for this method is 54 (max allowed is 50). | 74 |
| The String "Properties" appears 2 times in the file. | 76 |
| '600' is a magic number. | 102 |
| '420' is a magic number. | 102 |
| Parameter e should be final. | 115 |
| Parameter e should be final. | 126 |
| Parameter e should be final. | 147 |
| Parameter evt should be final. | 174 |
| Method 'setLog' is not designed for extension - needs to be abstract, final or empty. | 178 |
| Parameter genericLog should be final. | 178 |
| Uncommented main method found. | 193 |
| Parameter args should be final. | 193 |
| Array brackets at illegal position. | 193 |
| Anonymous inner class length is 21 lines (max allowed is 20). | 194 |
| Must have at least one statement. | 201 |
| Must have at least one statement. | 203 |
| Must have at least one statement. | 205 |
| Must have at least one statement. | 207 |
| Method 'getEntireGraphingPanel' is not designed for extension - needs to be abstract, final or empty. | 217 |
| '{' is not preceded with whitespace. | 217 |
| Method 'getMultiGraphLayeredPane' is not designed for extension - needs to be abstract, final or empty. | 221 |
| Method 'getGraphPositionPanel' is not designed for extension - needs to be abstract, final or empty. | 225 |
| Method 'getGraphMenu' is not designed for extension - needs to be abstract, final or empty. | 229 |
| Method 'getOptionFrame' is not designed for extension - needs to be abstract, final or empty. | 233 |
| Method 'getPropertyPane' is not designed for extension - needs to be abstract, final or empty. | 237 |
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. | 241 |
| Declaring variables, return values or parameters of type 'ArrayList' is not allowed. | 241 |
| Cyclomatic Complexity is 13 (max allowed is 10). | 245 |
| Executable statement count is 31 (max allowed is 30). | 245 |
| Method 'openFile' is not designed for extension - needs to be abstract, final or empty. | 245 |
| Variable 'fileChooser' should be declared final. | 246 |
| Variable 'lastFingFile' should be declared final. | 247 |
| The String "lastFingFile" appears 2 times in the file. | 247 |
| Variable 'lastFingDir' should be declared final. | 251 |
| The String "lastFingDir" appears 2 times in the file. | 251 |
| Variable 'chooserClass' should be declared final. | 259 |
| The String "chooserClass" appears 5 times in the file. | 259 |
| Variable 'acceptValue' should be declared final. | 275 |
| Variable 'openFile' should be declared final. | 277 |
| String literal expressions should be on the left side of an equals comparison. | 278 |
| String literal expressions should be on the left side of an equals comparison. | 280 |
| Parameter key should be final. | 295 |
| Name 'AppWide' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 297 |
| Variable 'AppWide' should be declared final. | 297 |
| Name 'AppWideFile' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 298 |
| Variable 'AppWideFile' should be declared final. | 298 |
| The String "received null instead of valid file" appears 3 times in the file. | 302 |
| Parameter key should be final. | 310 |
| Parameter value should be final. | 310 |
| Name 'AppWide' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 312 |
| Variable 'AppWide' should be declared final. | 312 |
| Name 'AppWideFile' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 313 |
| Variable 'AppWideFile' should be declared final. | 313 |
| The String "saved" appears 2 times in the file. | 316 |
| Parameter key should be final. | 326 |
| Name 'AppWide' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 328 |
| Variable 'AppWide' should be declared final. | 328 |
| Name 'AppWideFile' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 329 |
| Variable 'AppWideFile' should be declared final. | 329 |
| Parameter AppWide should be final. | 342 |
| Name 'AppWide' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 342 |
| Name 'AppWideFile' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 343 |
| The String "OLVAllProperties.olv" appears 2 times in the file. | 354 |
| Must have at least one statement. | 358 |
| Name 'IOE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 361 |
| Static variable definition in wrong order. | 374 |
| Variable 'mainAppRef' must be private and have accessor methods. | 374 |
| Instance variable definition in wrong order. | 375 |
| Instance variable definition in wrong order. | 376 |
| Instance variable definition in wrong order. | 377 |
| Instance variable definition in wrong order. | 378 |
| Instance variable definition in wrong order. | 379 |
| Instance variable definition in wrong order. | 380 |
| Instance variable definition in wrong order. | 381 |
| Instance variable definition in wrong order. | 382 |
| Instance variable definition in wrong order. | 383 |
| Instance variable definition in wrong order. | 384 |
| Instance variable definition in wrong order. | 385 |
| Instance variable definition in wrong order. | 386 |
| Instance variable definition in wrong order. | 387 |
| Declaring variables, return values or parameters of type 'ArrayList' is not allowed. | 387 |
| Static variable definition in wrong order. | 388 |
| Violation | Message | Line |
|---|---|---|
| Executable statement count is 75 (max allowed is 30). | 59 |
| NCSS for this method is 92 (max allowed is 50). | 59 |
| '857' is a magic number. | 61 |
| '40' is a magic number. | 61 |
| Parameter e should be final. | 73 |
| Parameter e should be final. | 88 |
| Parameter e should be final. | 103 |
| Parameter e should be final. | 118 |
| Parameter e should be final. | 133 |
| Parameter e should be final. | 148 |
| Parameter e should be final. | 163 |
| Parameter e should be final. | 178 |
| Parameter e should be final. | 188 |
| '{' is not preceded with whitespace. | 188 |
| Parameter e should be final. | 195 |
| '{' is not preceded with whitespace. | 195 |
| Parameter e should be final. | 202 |
| Parameter e should be final. | 210 |
| Parameter e should be final. | 217 |
| Parameter e should be final. | 224 |
| Parameter e should be final. | 231 |
| Parameter e should be final. | 238 |
| method def child at indentation level 9 not at correct indentation, 8 | 241 |
| Instance variable definition in wrong order. | 244 |
| Instance variable definition in wrong order. | 245 |
| Instance variable definition in wrong order. | 246 |
| Instance variable definition in wrong order. | 247 |
| Instance variable definition in wrong order. | 248 |
| Instance variable definition in wrong order. | 249 |
| Instance variable definition in wrong order. | 250 |
| Instance variable definition in wrong order. | 251 |
| Static variable definition in wrong order. | 252 |
| Violation | Message | Line |
|---|---|---|
| File does not end with a newline. | 0 |
| Redundant import from the same package - org.diyefi.openlogviewer.coloring.MarkedColor. | 29 |
| '{' is not preceded with whitespace. | 36 |
| '{' is not preceded with whitespace. | 40 |
| '0.25F' is a magic number. | 43 |
| '0.5F' is a magic number. | 44 |
| '0.75F' is a magic number. | 45 |
| 'for' is not followed by whitespace. | 46 |
| '8' is a magic number. | 46 |
| '128' is a magic number. | 46 |
| '*=' is not preceded with whitespace. | 46 |
| '*=' is not followed by whitespace. | 46 |
| Parameter hueOffsetDinominator should be final. | 51 |
| '{' is not preceded with whitespace. | 51 |
| Variable 'numColors' should be declared final. | 52 |
| '/' is not preceded with whitespace. | 52 |
| '/' is not followed by whitespace. | 52 |
| Variable 'hueOffset' should be declared final. | 53 |
| '/' is not preceded with whitespace. | 53 |
| '/' is not followed by whitespace. | 53 |
| 'for' is not followed by whitespace. | 54 |
| '{' is not preceded with whitespace. | 54 |
| 'for' is not followed by whitespace. | 57 |
| '4' is a magic number. | 57 |
| '{' is not preceded with whitespace. | 57 |
| Variable 'newColor' should be declared final. | 58 |
| 'cast' is not followed by whitespace. | 58 |
| 'if' is not followed by whitespace. | 59 |
| '{' is not preceded with whitespace. | 59 |
| '0.25' is a magic number. | 62 |
| '{' is not preceded with whitespace. | 67 |
| Variable 'i' should be declared final. | 69 |
| 'for' is not followed by whitespace. | 70 |
| '{' is not preceded with whitespace. | 70 |
| Variable 'c' should be declared final. | 71 |
| 'if' is not followed by whitespace. | 72 |
| '{' is not preceded with whitespace. | 72 |
| Control variable 'found' is modified. | 75 |
| Parameter c should be final. | 81 |
| '{' is not preceded with whitespace. | 81 |
| 'if' is not followed by whitespace. | 82 |
| '{' is not preceded with whitespace. | 82 |
| Instance variable definition in wrong order. | 87 |
| Declaring variables, return values or parameters of type 'LinkedList' is not allowed. | 87 |
| Violation | Message | Line |
|---|---|---|
| File does not end with a newline. | 0 |
| '{' is not preceded with whitespace. | 31 |
| '{' is not preceded with whitespace. | 33 |
| Parameter color should be final. | 39 |
| 'color' hides a field. | 39 |
| '{' is not preceded with whitespace. | 39 |
| Parameter availability should be final. | 45 |
| 'availability' hides a field. | 45 |
| '{' is not preceded with whitespace. | 45 |
| Parameter color should be final. | 51 |
| 'color' hides a field. | 51 |
| Parameter availability should be final. | 51 |
| 'availability' hides a field. | 51 |
| '{' is not preceded with whitespace. | 51 |
| Parameter color should be final. | 57 |
| 'color' hides a field. | 57 |
| Parameter availability should be final. | 57 |
| 'availability' hides a field. | 57 |
| Parameter hue should be final. | 57 |
| 'hue' hides a field. | 57 |
| '{' is not preceded with whitespace. | 57 |
| Method 'getColor' is not designed for extension - needs to be abstract, final or empty. | 63 |
| '{' is not preceded with whitespace. | 63 |
| Method 'setColor' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter color should be final. | 67 |
| 'color' hides a field. | 67 |
| '{' is not preceded with whitespace. | 67 |
| Method 'isAvailable' is not designed for extension - needs to be abstract, final or empty. | 71 |
| '{' is not preceded with whitespace. | 71 |
| Method 'setAvailability' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter availability should be final. | 75 |
| 'availability' hides a field. | 75 |
| '{' is not preceded with whitespace. | 75 |
| Method 'getHue' is not designed for extension - needs to be abstract, final or empty. | 79 |
| '{' is not preceded with whitespace. | 79 |
| Method 'setHue' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Parameter hue should be final. | 83 |
| 'hue' hides a field. | 83 |
| '{' is not preceded with whitespace. | 83 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 87 |
| covariant equals without overriding equals(java.lang.Object). | 87 |
| Parameter c should be final. | 87 |
| '{' is not preceded with whitespace. | 87 |
| Definition of 'equals()' without corresponding definition of 'hashCode()'. | 91 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 91 |
| covariant equals without overriding equals(java.lang.Object). | 91 |
| Parameter c should be final. | 91 |
| '{' is not preceded with whitespace. | 91 |
| Instance variable definition in wrong order. | 95 |
| Instance variable definition in wrong order. | 96 |
| Instance variable definition in wrong order. | 97 |
| Variable access definition in wrong order. | 97 |
| Variable 'hue' must be private and have accessor methods. | 97 |
| Violation | Message | Line |
|---|---|---|
| Name 'BaseDecoder' must match pattern '^Abstract.*$|^.*Factory$'. | 44 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Name 'IOE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 70 |
| '+' is not followed by whitespace. | 72 |
| Method 'getDecodedLog' is not designed for extension - needs to be abstract, final or empty. | 86 |
| Method 'setDecodedLog' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Parameter decodedLog should be final. | 93 |
| 'decodedLog' hides a field. | 93 |
| Method 'getLogFile' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Method 'setLogFile' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Parameter logFile should be final. | 107 |
| 'logFile' hides a field. | 107 |
| Method 'getT' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Method 'setT' is not designed for extension - needs to be abstract, final or empty. | 124 |
| Parameter t should be final. | 124 |
| 't' hides a field. | 124 |
| Violation | Message | Line |
|---|---|---|
| Parameter path should be final. | 42 |
| Parameter f should be final. | 53 |
| Method 'decodeLog' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Variable 'scan' should be declared final. | 72 |
| Instance variable definition in wrong order. | 102 |
| Variable 'fieldCount' must be private and have accessor methods. | 102 |
| Variable 'delim' should be declared final. | 111 |
| Array brackets at illegal position. | 111 |
| Variable 'scan' should be declared final. | 112 |
| '10' is a magic number. | 116 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 160 characters. | 46 |
| Name 'ESCAPE_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 48 |
| Name 'START_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 49 |
| Name 'STOP_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 50 |
| Name 'ESCAPED_ESCAPE_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 51 |
| Name 'ESCAPED_START_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 52 |
| Name 'ESCAPED_STOP_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 53 |
| Variable access definition in wrong order. | 63 |
| Variable 'coreStatusAFlagNames' must be private and have accessor methods. | 63 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 64 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 65 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 66 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 67 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 68 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 69 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 70 |
| array initialization child at indentation level 12 not at correct indentation, [8, 37] | 71 |
| Array should contain trailing comma. | 72 |
| array initialization rcurly at indentation level 8 not at correct indentation, 4 | 72 |
| Variable access definition in wrong order. | 74 |
| Variable 'decoderFlagsFlagNames' must be private and have accessor methods. | 74 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 75 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 76 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 77 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 78 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 79 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 80 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 81 |
| array initialization child at indentation level 12 not at correct indentation, [8, 38] | 82 |
| Array should contain trailing comma. | 83 |
| array initialization rcurly at indentation level 8 not at correct indentation, 4 | 83 |
| Variable access definition in wrong order. | 85 |
| Variable 'flaggableFlagsNames' must be private and have accessor methods. | 85 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 86 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 87 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 88 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 89 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 90 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 91 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 92 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 93 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 94 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 95 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 96 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 97 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 98 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 99 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 100 |
| array initialization child at indentation level 12 not at correct indentation, [8, 36] | 101 |
| Array should contain trailing comma. | 102 |
| Line is longer than 160 characters. | 104 |
| '{' is followed by whitespace. | 104 |
| '100' is a magic number. | 106 |
| '100' is a magic number. | 107 |
| '640' is a magic number. | 108 |
| '32768' is a magic number. | 109 |
| '100' is a magic number. | 110 |
| '100' is a magic number. | 111 |
| '1000' is a magic number. | 112 |
| '100' is a magic number. | 113 |
| '32768' is a magic number. | 114 |
| '100' is a magic number. | 115 |
| '512' is a magic number. | 124 |
| '512' is a magic number. | 125 |
| '32768' is a magic number. | 126 |
| '1250' is a magic number. | 129 |
| '100.0' is a magic number. | 130 |
| '/' is not preceded with whitespace. | 130 |
| '/' is not followed by whitespace. | 130 |
| '32768.0' is a magic number. | 130 |
| '1250' is a magic number. | 131 |
| '1250' is a magic number. | 132 |
| '1250' is a magic number. | 133 |
| '1250' is a magic number. | 134 |
| '50' is a magic number. | 135 |
| '1250' is a magic number. | 136 |
| ',' is not followed by whitespace. | 142 |
| Line is longer than 160 characters. | 150 |
| '8' is a magic number. | 163 |
| Array should contain trailing comma. | 164 |
| Parameter path should be final. | 173 |
| Parameter f should be final. | 181 |
| '6000' is a magic number. | 184 |
| Variable 'headers' should be declared final. | 188 |
| '32' is a magic number. | 188 |
| 'for' is not followed by whitespace. | 190 |
| '=' is not preceded with whitespace. | 190 |
| '=' is not followed by whitespace. | 190 |
| ';' is not followed by whitespace. | 190 |
| '<' is not preceded with whitespace. | 190 |
| '<' is not followed by whitespace. | 190 |
| ';' is not followed by whitespace. | 190 |
| '{' is not preceded with whitespace. | 190 |
| 'if' is not followed by whitespace. | 191 |
| '{' is not preceded with whitespace. | 191 |
| 'for' is not followed by whitespace. | 192 |
| '=' is not preceded with whitespace. | 192 |
| '=' is not followed by whitespace. | 192 |
| ';' is not followed by whitespace. | 192 |
| '<' is not preceded with whitespace. | 192 |
| '<' is not followed by whitespace. | 192 |
| ';' is not followed by whitespace. | 192 |
| '{' is not preceded with whitespace. | 192 |
| Variable 'flagID' should be declared final. | 193 |
| The String "-" appears 2 times in the file. | 193 |
| The String "-B" appears 2 times in the file. | 193 |
| '+' is not preceded with whitespace. | 193 |
| 'else' is not preceded with whitespace. | 197 |
| '}' is not followed by whitespace. | 197 |
| 'else' is not followed by whitespace. | 197 |
| '{' is not preceded with whitespace. | 197 |
| Cyclomatic Complexity is 15 (max allowed is 10). | 215 |
| Executable statement count is 58 (max allowed is 30). | 215 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 215 |
| NCSS for this method is 73 (max allowed is 50). | 215 |
| Variable 'readByte' should be declared final. | 219 |
| 'if' is not followed by whitespace. | 247 |
| '{' is not preceded with whitespace. | 247 |
| 'else' is not preceded with whitespace. | 249 |
| '}' is not followed by whitespace. | 249 |
| 'if' is not followed by whitespace. | 249 |
| '{' is not preceded with whitespace. | 249 |
| 'else' is not preceded with whitespace. | 251 |
| '}' is not followed by whitespace. | 251 |
| 'else' is not followed by whitespace. | 251 |
| '{' is not preceded with whitespace. | 251 |
| Variable 'justThePacket' should be declared final. | 252 |
| 'for' is not followed by whitespace. | 253 |
| '=' is not preceded with whitespace. | 253 |
| '=' is not followed by whitespace. | 253 |
| ';' is not followed by whitespace. | 253 |
| '<' is not preceded with whitespace. | 253 |
| '<' is not followed by whitespace. | 253 |
| ';' is not followed by whitespace. | 253 |
| '{' is not preceded with whitespace. | 253 |
| Nested if-else depth is 3 (max allowed is 2). | 256 |
| '{' is not preceded with whitespace. | 256 |
| '{' is not followed by whitespace. | 256 |
| Nested if-else depth is 4 (max allowed is 2). | 257 |
| 'if' is not followed by whitespace. | 257 |
| '{' is not preceded with whitespace. | 257 |
| 'else' is not preceded with whitespace. | 259 |
| '}' is not followed by whitespace. | 259 |
| 'else' is not followed by whitespace. | 259 |
| '{' is not preceded with whitespace. | 259 |
| 'else' is not preceded with whitespace. | 263 |
| '}' is not followed by whitespace. | 263 |
| 'else' is not followed by whitespace. | 263 |
| '{' is not preceded with whitespace. | 263 |
| Nested if-else depth is 3 (max allowed is 2). | 271 |
| 'else' is not preceded with whitespace. | 283 |
| '}' is not followed by whitespace. | 283 |
| 'else' is not followed by whitespace. | 283 |
| '{' is not preceded with whitespace. | 283 |
| The String "line.separator" appears 3 times in the file. | 289 |
| The String "Value: " appears 9 times in the file. | 291 |
| Name 'IOE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 303 |
| Cyclomatic Complexity is 18 (max allowed is 10). | 315 |
| Executable statement count is 46 (max allowed is 30). | 315 |
| NCSS for this method is 59 (max allowed is 50). | 315 |
| NPath Complexity is 480 (max allowed is 200). | 315 |
| Return count is 3 (max allowed is 2). | 315 |
| Parameter packet should be final. | 315 |
| Parameter payloadIDToParse should be final. | 315 |
| 'payloadIDToParse' hides a field. | 315 |
| Name 'HEADER_HAS_LENGTH_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 316 |
| Name 'HEADER_IS_NACK_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 317 |
| Name 'HEADER_HAS_SEQUENCE_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 318 |
| Name 'HEADER_RESERVED_E_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 319 |
| Name 'HEADER_RESERVED_D_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 320 |
| Name 'HEADER_RESERVED_C_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 321 |
| Name 'HEADER_RESERVED_B_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 322 |
| Name 'HEADER_RESERVED_A_INDEX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 323 |
| Variable 'flags' should be declared final. | 328 |
| Variable 'payloadIdUpper' should be declared final. | 331 |
| Variable 'payloadIdLower' should be declared final. | 333 |
| Variable 'payloadId' should be declared final. | 335 |
| '256' is a magic number. | 335 |
| 'if' is not followed by whitespace. | 337 |
| '{' is not preceded with whitespace. | 337 |
| Variable 'flagValues' should be declared final. | 341 |
| '8' is a magic number. | 341 |
| 'if' is not followed by whitespace. | 343 |
| '{' is not preceded with whitespace. | 343 |
| 'if' is not followed by whitespace. | 347 |
| '{' is not preceded with whitespace. | 347 |
| Line is longer than 160 characters. | 351 |
| 'for' is not followed by whitespace. | 352 |
| '=' is not preceded with whitespace. | 352 |
| '=' is not followed by whitespace. | 352 |
| ';' is not followed by whitespace. | 352 |
| '<' is not preceded with whitespace. | 352 |
| '<' is not followed by whitespace. | 352 |
| ';' is not followed by whitespace. | 352 |
| '{' is not preceded with whitespace. | 352 |
| Variable 'payloadLength' should be declared final. | 356 |
| 'if' is not followed by whitespace. | 357 |
| '{' is not preceded with whitespace. | 357 |
| 'for' is not followed by whitespace. | 364 |
| '=' is not preceded with whitespace. | 364 |
| '=' is not followed by whitespace. | 364 |
| ';' is not followed by whitespace. | 364 |
| '<' is not preceded with whitespace. | 364 |
| '<' is not followed by whitespace. | 364 |
| ';' is not followed by whitespace. | 364 |
| '{' is not preceded with whitespace. | 364 |
| Variable 'field' should be declared final. | 365 |
| 'for' is not followed by whitespace. | 368 |
| '=' is not preceded with whitespace. | 368 |
| '=' is not followed by whitespace. | 368 |
| ';' is not followed by whitespace. | 368 |
| '<' is not preceded with whitespace. | 368 |
| '<' is not followed by whitespace. | 368 |
| ';' is not followed by whitespace. | 368 |
| '{' is not preceded with whitespace. | 368 |
| '256' is a magic number. | 369 |
| 'if' is not followed by whitespace. | 373 |
| '{' is not preceded with whitespace. | 373 |
| Variable 'scaledValue' should be declared final. | 374 |
| 'cast' is not followed by whitespace. | 374 |
| '/' is not preceded with whitespace. | 374 |
| '/' is not followed by whitespace. | 374 |
| Variable 'finalValue' should be declared final. | 375 |
| 'else' is not preceded with whitespace. | 377 |
| '}' is not followed by whitespace. | 377 |
| 'if' is not followed by whitespace. | 377 |
| '{' is not preceded with whitespace. | 377 |
| Variable 'processedFlags' should be declared final. | 378 |
| '8' is a magic number. | 378 |
| 'for' is not followed by whitespace. | 379 |
| '=' is not preceded with whitespace. | 379 |
| '=' is not followed by whitespace. | 379 |
| ';' is not followed by whitespace. | 379 |
| '<' is not preceded with whitespace. | 379 |
| '<' is not followed by whitespace. | 379 |
| ';' is not followed by whitespace. | 379 |
| '{' is not preceded with whitespace. | 379 |
| Variable 'flagID' should be declared final. | 380 |
| '+' is not preceded with whitespace. | 380 |
| 'else' is not preceded with whitespace. | 383 |
| '}' is not followed by whitespace. | 383 |
| 'if' is not followed by whitespace. | 383 |
| '{' is not preceded with whitespace. | 383 |
| 'else' is not preceded with whitespace. | 385 |
| '}' is not followed by whitespace. | 385 |
| 'if' is not followed by whitespace. | 385 |
| '{' is not preceded with whitespace. | 385 |
| 'else' is not preceded with whitespace. | 387 |
| '}' is not followed by whitespace. | 387 |
| 'if' is not followed by whitespace. | 387 |
| '{' is not preceded with whitespace. | 387 |
| Method 'processFlagBytes' is not designed for extension - needs to be abstract, final or empty. | 394 |
| Parameter valueOfFlags should be final. | 394 |
| Parameter numberOfFlags should be final. | 394 |
| '{' is not preceded with whitespace. | 394 |
| 'if' is not followed by whitespace. | 395 |
| '8' is a magic number. | 395 |
| '16' is a magic number. | 395 |
| '32' is a magic number. | 395 |
| '{' is not preceded with whitespace. | 395 |
| Line is longer than 160 characters. | 396 |
| Variable 'flagValues' should be declared final. | 399 |
| 'for' is not followed by whitespace. | 401 |
| '=' is not preceded with whitespace. | 401 |
| '=' is not followed by whitespace. | 401 |
| ';' is not followed by whitespace. | 401 |
| '<' is not preceded with whitespace. | 401 |
| '<' is not followed by whitespace. | 401 |
| ';' is not followed by whitespace. | 401 |
| '{' is not preceded with whitespace. | 401 |
| 'if' is not followed by whitespace. | 402 |
| '{' is not preceded with whitespace. | 402 |
| Assignment of parameter 'valueOfFlags' is not allowed. | 404 |
| Parameter packet should be final. | 418 |
| 'if' is not followed by whitespace. | 419 |
| '{' is not preceded with whitespace. | 419 |
| Variable 'includedSum' should be declared final. | 420 |
| '-' is not followed by whitespace. | 420 |
| 'for' is not followed by whitespace. | 422 |
| '=' is not preceded with whitespace. | 422 |
| '=' is not followed by whitespace. | 422 |
| ';' is not followed by whitespace. | 422 |
| '<' is not preceded with whitespace. | 422 |
| '<' is not followed by whitespace. | 422 |
| '-' is not preceded with whitespace. | 422 |
| '-' is not followed by whitespace. | 422 |
| ';' is not followed by whitespace. | 422 |
| '{' is not preceded with whitespace. | 422 |
| Variable 'calculatedSum' should be declared final. | 425 |
| 'cast' is not followed by whitespace. | 425 |
| '256' is a magic number. | 425 |
| 'else' is not preceded with whitespace. | 427 |
| '}' is not followed by whitespace. | 427 |
| 'else' is not followed by whitespace. | 427 |
| '{' is not preceded with whitespace. | 427 |
| Return count is 4 (max allowed is 2). | 438 |
| Parameter uByte should be final. | 438 |
| Parameter uInt8 should be final. | 456 |
| '{' is not preceded with whitespace. | 456 |
| 'cast' is not followed by whitespace. | 457 |
| '0xFF' is a magic number. | 457 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 478 |
| Violation | Message | Line |
|---|---|---|
| Name 'ESCAPE_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| ';' is not followed by whitespace. | 36 |
| Name 'START_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 37 |
| ';' is not followed by whitespace. | 37 |
| Name 'STOP_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| ';' is not followed by whitespace. | 38 |
| Name 'ESCAPED_ESCAPE_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 39 |
| ';' is not followed by whitespace. | 39 |
| Name 'ESCAPED_START_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 40 |
| ';' is not followed by whitespace. | 40 |
| Name 'ESCAPED_STOP_BYTE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 41 |
| ';' is not followed by whitespace. | 41 |
| ';' is not followed by whitespace. | 43 |
| Variable access definition in wrong order. | 50 |
| Variable 'headers' must be private and have accessor methods. | 50 |
| array initialization child at indentation level 12 not at correct indentation, 8 | 51 |
| The String "PTIT" appears 2 times in the file. | 51 |
| The String "T0" appears 2 times in the file. | 51 |
| The String "T1" appears 2 times in the file. | 51 |
| The String "T2" appears 2 times in the file. | 51 |
| The String "T3" appears 2 times in the file. | 51 |
| The String "T4" appears 2 times in the file. | 51 |
| The String "T5" appears 2 times in the file. | 51 |
| The String "T6" appears 2 times in the file. | 51 |
| The String "T7" appears 2 times in the file. | 51 |
| Array should contain trailing comma. | 52 |
| array initialization rcurly at indentation level 8 not at correct indentation, 4 | 52 |
| Parameter path should be final. | 61 |
| Parameter f should be final. | 72 |
| '3000' is a magic number. | 75 |
| Cyclomatic Complexity is 11 (max allowed is 10). | 91 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 91 |
| Variable 'readByte' should be declared final. | 94 |
| ';' is not followed by whitespace. | 95 |
| '0xff' is a magic number. | 102 |
| Must have at least one statement. | 106 |
| '0xff' is a magic number. | 119 |
| Nested if-else depth is 3 (max allowed is 2). | 120 |
| Name 'IOE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 139 |
| Executable statement count is 37 (max allowed is 30). | 153 |
| NPath Complexity is 256 (max allowed is 200). | 153 |
| Parameter packet should be final. | 153 |
| Parameter length should be final. | 153 |
| Name 'PTIT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 154 |
| 'cast' is not followed by whitespace. | 154 |
| '3' is a magic number. | 154 |
| Name 'T0' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 155 |
| Name 'T1' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 156 |
| Name 'T2' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 157 |
| Name 'T3' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 158 |
| Name 'T4' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 159 |
| Name 'T5' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 160 |
| Name 'T6' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 161 |
| Name 'T7' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 162 |
| 'if' is not followed by whitespace. | 165 |
| '{' is not preceded with whitespace. | 165 |
| 'if' is not followed by whitespace. | 169 |
| '4' is a magic number. | 169 |
| '{' is not preceded with whitespace. | 169 |
| 'if' is not followed by whitespace. | 173 |
| '8' is a magic number. | 173 |
| '4' is a magic number. | 173 |
| '{' is not preceded with whitespace. | 173 |
| '4' is a magic number. | 175 |
| 'if' is not followed by whitespace. | 177 |
| '16' is a magic number. | 177 |
| '8' is a magic number. | 177 |
| '{' is not preceded with whitespace. | 177 |
| '8' is a magic number. | 179 |
| 'if' is not followed by whitespace. | 181 |
| '32' is a magic number. | 181 |
| '16' is a magic number. | 181 |
| '{' is not preceded with whitespace. | 181 |
| '16' is a magic number. | 183 |
| 'if' is not followed by whitespace. | 185 |
| '64' is a magic number. | 185 |
| '32' is a magic number. | 185 |
| '{' is not preceded with whitespace. | 185 |
| '32' is a magic number. | 187 |
| 'if' is not followed by whitespace. | 189 |
| '128' is a magic number. | 189 |
| '64' is a magic number. | 189 |
| '{' is not preceded with whitespace. | 189 |
| '64' is a magic number. | 191 |
| 'if' is not followed by whitespace. | 193 |
| '128' is a magic number. | 193 |
| '{' is not preceded with whitespace. | 193 |
| Parameter packet should be final. | 213 |
| Parameter length should be final. | 213 |
| 'if' is not followed by whitespace. | 214 |
| '{' is not preceded with whitespace. | 214 |
| Variable 'includedSum' should be declared final. | 215 |
| '-' is not followed by whitespace. | 215 |
| 'for' is not followed by whitespace. | 217 |
| '=' is not preceded with whitespace. | 217 |
| '=' is not followed by whitespace. | 217 |
| ';' is not followed by whitespace. | 217 |
| '<' is not preceded with whitespace. | 217 |
| '<' is not followed by whitespace. | 217 |
| '-' is not preceded with whitespace. | 217 |
| '-' is not followed by whitespace. | 217 |
| ';' is not followed by whitespace. | 217 |
| '{' is not preceded with whitespace. | 217 |
| Variable 'calculatedSum' should be declared final. | 220 |
| 'cast' is not followed by whitespace. | 220 |
| '256' is a magic number. | 220 |
| Avoid inline conditionals. | 221 |
| 'else' is not preceded with whitespace. | 222 |
| '}' is not followed by whitespace. | 222 |
| 'else' is not followed by whitespace. | 222 |
| '{' is not preceded with whitespace. | 222 |
| Return count is 4 (max allowed is 2). | 232 |
| Parameter uByte should be final. | 232 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 263 |
| Violation | Message | Line |
|---|---|---|
| Array brackets at illegal position. | 50 |
| Parameter rawPacket should be final. | 55 |
| Array brackets at illegal position. | 55 |
| Method 'hasLength' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Method 'isNack' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Method 'hasSequence' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Method 'reserved3' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Method 'reserved4' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Method 'reserved5' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Method 'reserved6' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Method 'reserved7' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Method 'getLength' is not designed for extension - needs to be abstract, final or empty. | 91 |
| Method 'getSequence' is not designed for extension - needs to be abstract, final or empty. | 95 |
| 'if' is not followed by whitespace. | 96 |
| '{' is not preceded with whitespace. | 96 |
| 'else' is not preceded with whitespace. | 98 |
| '}' is not followed by whitespace. | 98 |
| 'else' is not followed by whitespace. | 98 |
| '{' is not preceded with whitespace. | 98 |
| Method 'getPayloadId' is not designed for extension - needs to be abstract, final or empty. | 103 |
| Method 'getErrorId' is not designed for extension - needs to be abstract, final or empty. | 107 |
| 'if' is not followed by whitespace. | 108 |
| '{' is not preceded with whitespace. | 108 |
| 'else' is not preceded with whitespace. | 110 |
| '}' is not followed by whitespace. | 110 |
| 'else' is not followed by whitespace. | 110 |
| '{' is not preceded with whitespace. | 110 |
| Method 'getPayload' is not designed for extension - needs to be abstract, final or empty. | 115 |
| Method 'getPayloadLength' is not designed for extension - needs to be abstract, final or empty. | 119 |
| Method 'getChecksum' is not designed for extension - needs to be abstract, final or empty. | 123 |
| Violation | Message | Line |
|---|---|---|
| File does not end with a newline. | 0 |
| Type Javadoc comment is missing an null tag. | 3 |
| '{' is not preceded with whitespace. | 3 |
| Type Javadoc comment is missing an null tag. | 4 |
| '{' is not preceded with whitespace. | 4 |
| Variable 'width' must be private and have accessor methods. | 15 |
| Parameter width should be final. | 17 |
| 'width' hides a field. | 17 |
| '{' is not preceded with whitespace. | 17 |
| Name 'divideByOne' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 23 |
| Name 'addToZero' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 24 |
| Parameter ID should be final. | 26 |
| 'ID' hides a field. | 26 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 26 |
| '{' is not preceded with whitespace. | 26 |
| Parameter ID should be final. | 29 |
| 'ID' hides a field. | 29 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 29 |
| Parameter type should be final. | 29 |
| 'type' hides a field. | 29 |
| '{' is not preceded with whitespace. | 29 |
| Parameter ID should be final. | 32 |
| 'ID' hides a field. | 32 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 32 |
| Parameter type should be final. | 32 |
| 'type' hides a field. | 32 |
| Parameter divBy should be final. | 32 |
| 'divBy' hides a field. | 32 |
| '{' is not preceded with whitespace. | 32 |
| ',' is not followed by whitespace. | 33 |
| Parameter ID should be final. | 36 |
| 'ID' hides a field. | 36 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| Parameter divBy should be final. | 36 |
| 'divBy' hides a field. | 36 |
| '{' is not preceded with whitespace. | 36 |
| Parameter ID should be final. | 39 |
| 'ID' hides a field. | 39 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 39 |
| Parameter divBy should be final. | 39 |
| 'divBy' hides a field. | 39 |
| Parameter addTo should be final. | 39 |
| 'addTo' hides a field. | 39 |
| '{' is not preceded with whitespace. | 39 |
| Parameter ID should be final. | 43 |
| 'ID' hides a field. | 43 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 43 |
| Parameter type should be final. | 43 |
| 'type' hides a field. | 43 |
| Parameter divBy should be final. | 43 |
| 'divBy' hides a field. | 43 |
| Parameter addTo should be final. | 43 |
| 'addTo' hides a field. | 43 |
| '{' is not preceded with whitespace. | 43 |
| 'if' is not followed by whitespace. | 49 |
| '{' is not preceded with whitespace. | 49 |
| The String "ID is null, needs to be a valid string!" appears 2 times in the file. | 50 |
| 'else' is not preceded with whitespace. | 51 |
| '}' is not followed by whitespace. | 51 |
| 'if' is not followed by whitespace. | 51 |
| '{' is not preceded with whitespace. | 51 |
| 'else' is not preceded with whitespace. | 53 |
| '}' is not followed by whitespace. | 53 |
| 'if' is not followed by whitespace. | 53 |
| '{' is not preceded with whitespace. | 53 |
| 'else' is not preceded with whitespace. | 55 |
| '}' is not followed by whitespace. | 55 |
| 'if' is not followed by whitespace. | 55 |
| '{' is not preceded with whitespace. | 55 |
| Cyclomatic Complexity is 12 (max allowed is 10). | 60 |
| Parameter ID should be final. | 60 |
| 'ID' hides a field. | 60 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 60 |
| Parameter type should be final. | 60 |
| 'type' hides a field. | 60 |
| Parameter bitFieldNames should be final. | 60 |
| 'bitFieldNames' hides a field. | 60 |
| '{' is not preceded with whitespace. | 60 |
| 'if' is not followed by whitespace. | 65 |
| '{' is not preceded with whitespace. | 65 |
| 'else' is not preceded with whitespace. | 67 |
| '}' is not followed by whitespace. | 67 |
| 'if' is not followed by whitespace. | 67 |
| '{' is not preceded with whitespace. | 67 |
| 'if' is not followed by whitespace. | 71 |
| '{' is not preceded with whitespace. | 71 |
| 'else' is not preceded with whitespace. | 73 |
| '}' is not followed by whitespace. | 73 |
| 'if' is not followed by whitespace. | 73 |
| '8' is a magic number. | 73 |
| '{' is not preceded with whitespace. | 73 |
| 'else' is not preceded with whitespace. | 75 |
| '}' is not followed by whitespace. | 75 |
| 'if' is not followed by whitespace. | 75 |
| '16' is a magic number. | 75 |
| '{' is not preceded with whitespace. | 75 |
| 'else' is not preceded with whitespace. | 77 |
| '}' is not followed by whitespace. | 77 |
| 'if' is not followed by whitespace. | 77 |
| '32' is a magic number. | 77 |
| '{' is not preceded with whitespace. | 77 |
| Instance variable definition in wrong order. | 82 |
| Name 'ID' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 82 |
| Variable 'ID' must be private and have accessor methods. | 82 |
| Instance variable definition in wrong order. | 83 |
| Variable 'type' must be private and have accessor methods. | 83 |
| Instance variable definition in wrong order. | 84 |
| Variable 'bitFieldNames' must be private and have accessor methods. | 84 |
| Instance variable definition in wrong order. | 87 |
| Variable 'description' must be private and have accessor methods. | 87 |
| Instance variable definition in wrong order. | 88 |
| Variable 'unit' must be private and have accessor methods. | 88 |
| Instance variable definition in wrong order. | 91 |
| Variable 'divBy' must be private and have accessor methods. | 91 |
| Instance variable definition in wrong order. | 92 |
| Variable 'addTo' must be private and have accessor methods. | 92 |
| Method 'getID' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Method 'getBitFieldNames' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Method 'getDivBy' is not designed for extension - needs to be abstract, final or empty. | 103 |
| Method 'getAddTo' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Method 'setID' is not designed for extension - needs to be abstract, final or empty. | 109 |
| Parameter iD should be final. | 109 |
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. | 112 |
| Parameter type should be final. | 112 |
| 'type' hides a field. | 112 |
| Method 'setBitFieldNames' is not designed for extension - needs to be abstract, final or empty. | 115 |
| Parameter bitFieldNames should be final. | 115 |
| 'bitFieldNames' hides a field. | 115 |
| Method 'setDivBy' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Parameter divBy should be final. | 118 |
| 'divBy' hides a field. | 118 |
| Method 'setAddTo' is not designed for extension - needs to be abstract, final or empty. | 121 |
| Parameter addTo should be final. | 121 |
| 'addTo' hides a field. | 121 |
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. | 124 |
| Method 'getUnit' is not designed for extension - needs to be abstract, final or empty. | 127 |
| Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Parameter description should be final. | 130 |
| 'description' hides a field. | 130 |
| Method 'setUnit' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Parameter unit should be final. | 133 |
| 'unit' hides a field. | 133 |
| Violation | Message | Line |
|---|---|---|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Method 'accept' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Return count is 6 (max allowed is 2). | 44 |
| Parameter f should be final. | 45 |
| Variable 'extension' should be declared final. | 49 |
| String literal expressions should be on the left side of an equals comparison. | 51 |
| String literal expressions should be on the left side of an equals comparison. | 53 |
| String literal expressions should be on the left side of an equals comparison. | 55 |
| 'else' is not preceded with whitespace. | 57 |
| '}' is not followed by whitespace. | 57 |
| String literal expressions should be on the left side of an equals comparison. | 57 |
| Violation | Message | Line |
|---|---|---|
| Using the '.*' form of import should be avoided - java.io.*. | 26 |
| '(' is preceded with whitespace. | 35 |
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. | 39 |
| method def child at indentation level 7 not at correct indentation, 8 | 41 |
| Method 'accept' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Return count is 3 (max allowed is 2). | 44 |
| Parameter f should be final. | 45 |
| 'if' is not followed by whitespace. | 46 |
| Variable 'extension' should be declared final. | 49 |
| 'if' construct must use '{}'s. | 50 |
| 'if' is not followed by whitespace. | 50 |
| String literal expressions should be on the left side of an equals comparison. | 50 |
| Violation | Message | Line |
|---|---|---|
| Using the '.*' form of import should be avoided - java.io.*. | 26 |
| '(' is preceded with whitespace. | 35 |
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. | 39 |
| method def child at indentation level 7 not at correct indentation, 8 | 41 |
| Method 'accept' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Return count is 3 (max allowed is 2). | 44 |
| Parameter f should be final. | 45 |
| 'if' is not followed by whitespace. | 46 |
| Variable 'extension' should be declared final. | 49 |
| 'if' construct must use '{}'s. | 50 |
| 'if' is not followed by whitespace. | 50 |
| String literal expressions should be on the left side of an equals comparison. | 50 |
| Violation | Message | Line |
|---|---|---|
| Name 'PCS' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 79 |
| '50000' is a magic number. | 89 |
| '3' is a magic number. | 105 |
| '+' is not preceded with whitespace. | 107 |
| '+' should be on a new line. | 107 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Parameter d should be final. | 119 |
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. | 135 |
| Parameter name should be final. | 135 |
| 'name' hides a field. | 135 |
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Method 'getMaxValue' is not designed for extension - needs to be abstract, final or empty. | 149 |
| Method 'setMaxValue' is not designed for extension - needs to be abstract, final or empty. | 157 |
| Parameter highValue should be final. | 157 |
| Method 'getMinValue' is not designed for extension - needs to be abstract, final or empty. | 164 |
| Method 'setMinValue' is not designed for extension - needs to be abstract, final or empty. | 171 |
| Parameter lowValue should be final. | 171 |
| Method 'getColor' is not designed for extension - needs to be abstract, final or empty. | 179 |
| Method 'setColor' is not designed for extension - needs to be abstract, final or empty. | 186 |
| Parameter c should be final. | 186 |
| Method 'getSplitNumber' is not designed for extension - needs to be abstract, final or empty. | 193 |
| Method 'setSplitNumber' is not designed for extension - needs to be abstract, final or empty. | 201 |
| Parameter splitNumber should be final. | 201 |
| 'splitNumber' hides a field. | 201 |
| 'if' is not followed by whitespace. | 202 |
| ')' is preceded with whitespace. | 202 |
| Assignment of parameter 'splitNumber' is not allowed. | 203 |
| Variable 'old' should be declared final. | 205 |
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. | 213 |
| Method 'addPropertyChangeListener' is not designed for extension - needs to be abstract, final or empty. | 219 |
| Parameter property should be final. | 219 |
| Parameter PCL should be final. | 219 |
| Name 'PCL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 219 |
| Method 'removePropertyChangeListener' is not designed for extension - needs to be abstract, final or empty. | 223 |
| Parameter property should be final. | 223 |
| Parameter PCL should be final. | 223 |
| Name 'PCL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 223 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 227 |
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. | 232 |
| Parameter o should be final. | 233 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 235 |
| Variable 'GDE' should be declared final. | 235 |
| Method 'getTransferData' is not designed for extension - needs to be abstract, final or empty. | 242 |
| Return count is 3 (max allowed is 2). | 242 |
| Parameter flavor should be final. | 243 |
| Throws count is 2 (max allowed is 1). | 243 |
| 'if' is not followed by whitespace. | 244 |
| 'else' is not preceded with whitespace. | 246 |
| '}' is not followed by whitespace. | 246 |
| 'if' is not followed by whitespace. | 246 |
| '{' is not preceded with whitespace. | 246 |
| The String "Unsupported" appears 2 times in the file. | 247 |
| 'else' is not preceded with whitespace. | 248 |
| '}' is not followed by whitespace. | 248 |
| 'if' is not followed by whitespace. | 248 |
| '{' is not preceded with whitespace. | 248 |
| '}' should be on the same line. | 250 |
| Method 'getTransferDataFlavors' is not designed for extension - needs to be abstract, final or empty. | 256 |
| Method 'isDataFlavorSupported' is not designed for extension - needs to be abstract, final or empty. | 261 |
| Parameter flavor should be final. | 262 |
| 'for' is not followed by whitespace. | 263 |
| '<' is not preceded with whitespace. | 263 |
| '<' is not followed by whitespace. | 263 |
| ';' is not followed by whitespace. | 263 |
| '{' is not preceded with whitespace. | 263 |
| 'if' is not followed by whitespace. | 264 |
| '{' is not preceded with whitespace. | 264 |
| Violation | Message | Line |
|---|---|---|
| Variable 'lineCount' explicitly initialized to '0' (default value for its type). | 43 |
| Static variable definition in wrong order. | 46 |
| Variable access definition in wrong order. | 46 |
| 'public' modifier out of order with the JLS suggestions. | 46 |
| Static variable definition in wrong order. | 47 |
| Variable access definition in wrong order. | 47 |
| 'public' modifier out of order with the JLS suggestions. | 47 |
| Static variable definition in wrong order. | 48 |
| Variable access definition in wrong order. | 48 |
| 'public' modifier out of order with the JLS suggestions. | 48 |
| Variable access definition in wrong order. | 51 |
| Name 'PCS' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 51 |
| Variable 'PCS' must be private and have accessor methods. | 51 |
| Variable 'genLog' should be declared final. | 57 |
| Variable 'genLog' should be declared final. | 61 |
| The String "LogLoaded" appears 3 times in the file. | 73 |
| Parameter headers should be final. | 83 |
| Variable 'internalHeaders' should be declared final. | 93 |
| 'for' is not followed by whitespace. | 94 |
| '=' is not preceded with whitespace. | 94 |
| '=' is not followed by whitespace. | 94 |
| ';' is not followed by whitespace. | 94 |
| '<' is not preceded with whitespace. | 94 |
| '<' is not followed by whitespace. | 94 |
| ';' is not followed by whitespace. | 94 |
| '{' is not preceded with whitespace. | 94 |
| Method 'addValue' is not designed for extension - needs to be abstract, final or empty. | 109 |
| Parameter key should be final. | 109 |
| Parameter value should be final. | 109 |
| Variable 'logElement' should be declared final. | 110 |
| 'if' is not followed by whitespace. | 111 |
| '{' is not preceded with whitespace. | 111 |
| 'cast' is not followed by whitespace. | 112 |
| Method 'setLogStatus' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Parameter newLogStatus should be final. | 122 |
| Variable 'oldLogStatus' should be declared final. | 123 |
| Method 'getLogStatus' is not designed for extension - needs to be abstract, final or empty. | 132 |
| Method 'setHeaders' is not designed for extension - needs to be abstract, final or empty. | 139 |
| Parameter headers should be final. | 139 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 141 |
| Variable 'GDE' should be declared final. | 141 |
| Method 'setMetaData' is not designed for extension - needs to be abstract, final or empty. | 152 |
| Parameter md should be final. | 152 |
| Method 'getMetadata' is not designed for extension - needs to be abstract, final or empty. | 160 |
| Method 'addPropertyChangeListener' is not designed for extension - needs to be abstract, final or empty. | 176 |
| Method 'removePropertyChangeListener' is not designed for extension - needs to be abstract, final or empty. | 185 |
| Violation | Message | Line |
|---|---|---|
| Redundant import from the same package - org.diyefi.openlogviewer.graphing.MultiGraphLayeredPane. | 42 |
| '600' is a magic number. | 59 |
| '400' is a magic number. | 59 |
| '600' is a magic number. | 62 |
| '20' is a magic number. | 62 |
| '10' is a magic number. | 68 |
| '10' is a magic number. | 70 |
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Parameter e should be final. | 83 |
| '{' is not preceded with whitespace. | 86 |
| 'if' is not followed by whitespace. | 87 |
| '{' is not preceded with whitespace. | 87 |
| 'else' is not followed by whitespace. | 89 |
| '{' is not preceded with whitespace. | 89 |
| Variable 'center' should be declared final. | 90 |
| 'if' is not followed by whitespace. | 92 |
| '{' is not preceded with whitespace. | 92 |
| Method 'getMultiGraphLayeredPane' is not designed for extension - needs to be abstract, final or empty. | 101 |
| '{' is not preceded with whitespace. | 101 |
| Method 'getGraphPositionPanel' is not designed for extension - needs to be abstract, final or empty. | 105 |
| '{' is not preceded with whitespace. | 105 |
| Method 'setLog' is not designed for extension - needs to be abstract, final or empty. | 109 |
| Parameter genLog should be final. | 109 |
| Method 'zoomIn' is not designed for extension - needs to be abstract, final or empty. | 116 |
| '500' is a magic number. | 117 |
| Method 'zoomOut' is not designed for extension - needs to be abstract, final or empty. | 123 |
| Method 'play' is not designed for extension - needs to be abstract, final or empty. | 130 |
| '{' is not preceded with whitespace. | 130 |
| Method 'pause' is not designed for extension - needs to be abstract, final or empty. | 141 |
| '{' is not preceded with whitespace. | 141 |
| Method 'fastForward' is not designed for extension - needs to be abstract, final or empty. | 151 |
| Variable 'currentDelay' should be declared final. | 152 |
| 'if' is not followed by whitespace. | 153 |
| '{' is not preceded with whitespace. | 153 |
| Method 'eject' is not designed for extension - needs to be abstract, final or empty. | 158 |
| Method 'stop' is not designed for extension - needs to be abstract, final or empty. | 162 |
| '{' is not preceded with whitespace. | 162 |
| Method 'slowDown' is not designed for extension - needs to be abstract, final or empty. | 172 |
| Variable 'currentDelay' should be declared final. | 173 |
| Method 'fling' is not designed for extension - needs to be abstract, final or empty. | 177 |
| '{' is not preceded with whitespace. | 177 |
| Method 'getGraphPosition' is not designed for extension - needs to be abstract, final or empty. | 182 |
| '{' is not preceded with whitespace. | 182 |
| Method 'getGraphPositionMax' is not designed for extension - needs to be abstract, final or empty. | 186 |
| '{' is not preceded with whitespace. | 186 |
| Method 'getZoom' is not designed for extension - needs to be abstract, final or empty. | 190 |
| '{' is not preceded with whitespace. | 190 |
| Parameter amount should be final. | 194 |
| '{' is not preceded with whitespace. | 194 |
| Variable 'newPos' should be declared final. | 195 |
| Method 'setGraphPosition' is not designed for extension - needs to be abstract, final or empty. | 199 |
| Parameter newPos should be final. | 199 |
| '{' is not preceded with whitespace. | 199 |
| Method 'setGraphPositionMax' is not designed for extension - needs to be abstract, final or empty. | 204 |
| '{' is not preceded with whitespace. | 204 |
| Variable 'gl' should be declared final. | 208 |
| '{' is not preceded with whitespace. | 215 |
| '{' is not preceded with whitespace. | 219 |
| Method 'isPlaying' is not designed for extension - needs to be abstract, final or empty. | 223 |
| '{' is not preceded with whitespace. | 223 |
| Parameter newPosition should be final. | 227 |
| '{' is not preceded with whitespace. | 227 |
| 'graphPosition' hides a field. | 228 |
| Variable 'graphPosition' should be declared final. | 228 |
| 'graphPositionMax' hides a field. | 229 |
| Variable 'graphPositionMax' should be declared final. | 229 |
| Variable 'center' should be declared final. | 230 |
| Variable 'move' should be declared final. | 231 |
| '{' is not preceded with whitespace. | 243 |
| '{' is not preceded with whitespace. | 248 |
| Method 'mouseClicked' is not designed for extension - needs to be abstract, final or empty. | 254 |
| Parameter e should be final. | 255 |
| Method 'mouseDragged' is not designed for extension - needs to be abstract, final or empty. | 264 |
| Parameter e should be final. | 265 |
| Variable 'center' should be declared final. | 267 |
| Variable 'xMouseCoord' should be declared final. | 268 |
| 'if' is not followed by whitespace. | 269 |
| '{' is not preceded with whitespace. | 269 |
| Parameter e should be final. | 278 |
| Parameter e should be final. | 283 |
| Parameter e should be final. | 288 |
| Method 'mousePressed' is not designed for extension - needs to be abstract, final or empty. | 292 |
| Parameter e should be final. | 293 |
| 'if' is not followed by whitespace. | 295 |
| '{' is not preceded with whitespace. | 295 |
| Method 'mouseReleased' is not designed for extension - needs to be abstract, final or empty. | 302 |
| Parameter e should be final. | 303 |
| Variable 'now' should be declared final. | 305 |
| 'if' is not followed by whitespace. | 306 |
| '50' is a magic number. | 306 |
| '{' is not preceded with whitespace. | 306 |
| 'if' is not followed by whitespace. | 309 |
| '{' is not preceded with whitespace. | 309 |
| 'if' is not followed by whitespace. | 312 |
| '{' is not preceded with whitespace. | 312 |
| Method 'mouseWheelMoved' is not designed for extension - needs to be abstract, final or empty. | 317 |
| Parameter e should be final. | 318 |
| Variable 'center' should be declared final. | 319 |
| Variable 'zoomInMove' should be declared final. | 320 |
| Variable 'zoomOutMove' should be declared final. | 321 |
| Variable 'notches' should be declared final. | 322 |
| 'if' is not followed by whitespace. | 323 |
| '{' is not preceded with whitespace. | 323 |
| '{' is not preceded with whitespace. | 326 |
| Cyclomatic Complexity is 22 (max allowed is 10). | 333 |
| Executable statement count is 38 (max allowed is 30). | 333 |
| Method 'keyPressed' is not designed for extension - needs to be abstract, final or empty. | 333 |
| NCSS for this method is 65 (max allowed is 50). | 333 |
| Parameter e should be final. | 334 |
| switch without "default" clause. | 335 |
| block child at indentation level 12 not at correct indentation, 16 | 337 |
| block child at indentation level 12 not at correct indentation, 16 | 340 |
| block child at indentation level 12 not at correct indentation, 16 | 343 |
| Avoid nested blocks. | 346 |
| '4' is a magic number. | 348 |
| block child at indentation level 12 not at correct indentation, 16 | 349 |
| Avoid nested blocks. | 350 |
| 'if' is not followed by whitespace. | 351 |
| '{' is not preceded with whitespace. | 351 |
| '4' is a magic number. | 353 |
| Variable 'center' should be declared final. | 355 |
| block child at indentation level 12 not at correct indentation, 16 | 358 |
| Avoid nested blocks. | 359 |
| 'if' is not followed by whitespace. | 360 |
| '{' is not preceded with whitespace. | 360 |
| '4' is a magic number. | 362 |
| Variable 'center' should be declared final. | 364 |
| block child at indentation level 12 not at correct indentation, 16 | 367 |
| Avoid nested blocks. | 370 |
| '4' is a magic number. | 372 |
| block child at indentation level 12 not at correct indentation, 16 | 373 |
| Avoid nested blocks. | 374 |
| 'if' is not followed by whitespace. | 375 |
| '{' is not preceded with whitespace. | 375 |
| '4' is a magic number. | 377 |
| Variable 'center' should be declared final. | 379 |
| block child at indentation level 12 not at correct indentation, 16 | 382 |
| Avoid nested blocks. | 383 |
| 'if' is not followed by whitespace. | 384 |
| '{' is not preceded with whitespace. | 384 |
| '4' is a magic number. | 386 |
| Variable 'center' should be declared final. | 388 |
| block child at indentation level 12 not at correct indentation, 16 | 391 |
| block child at indentation level 12 not at correct indentation, 16 | 394 |
| block child at indentation level 12 not at correct indentation, 16 | 395 |
| Avoid nested blocks. | 396 |
| 'if' is not followed by whitespace. | 397 |
| '{' is not preceded with whitespace. | 397 |
| block child at indentation level 12 not at correct indentation, 16 | 400 |
| block child at indentation level 12 not at correct indentation, 16 | 403 |
| block child at indentation level 12 not at correct indentation, 16 | 404 |
| Avoid nested blocks. | 405 |
| 'if' is not followed by whitespace. | 406 |
| '{' is not preceded with whitespace. | 406 |
| block child at indentation level 12 not at correct indentation, 16 | 409 |
| Parameter e should be final. | 415 |
| Parameter e should be final. | 420 |
| Instance variable definition in wrong order. | 424 |
| Instance variable definition in wrong order. | 425 |
| Instance variable definition in wrong order. | 426 |
| Instance variable definition in wrong order. | 427 |
| Instance variable definition in wrong order. | 428 |
| Instance variable definition in wrong order. | 429 |
| Instance variable definition in wrong order. | 430 |
| Instance variable definition in wrong order. | 431 |
| Instance variable definition in wrong order. | 432 |
| Instance variable definition in wrong order. | 433 |
| Instance variable definition in wrong order. | 434 |
| Instance variable definition in wrong order. | 435 |
| Instance variable definition in wrong order. | 436 |
| Instance variable definition in wrong order. | 437 |
| Static variable definition in wrong order. | 438 |
| Violation | Message | Line |
|---|---|---|
| '{' is not preceded with whitespace. | 45 |
| Method 'paint' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Parameter g should be final. | 57 |
| Variable 'g2d' should be declared final. | 62 |
| Parameter g2d should be final. | 76 |
| '{' is not preceded with whitespace. | 76 |
| Variable 'center' should be declared final. | 77 |
| Variable 'graphPosition' should be declared final. | 78 |
| Variable 'zoom' should be declared final. | 79 |
| 'for' is not followed by whitespace. | 83 |
| '{' is not preceded with whitespace. | 83 |
| 'if' is not followed by whitespace. | 84 |
| '{' is not preceded with whitespace. | 84 |
| '6' is a magic number. | 85 |
| 'for' is not followed by whitespace. | 91 |
| '{' is not preceded with whitespace. | 91 |
| 'if' is not followed by whitespace. | 92 |
| '{' is not preceded with whitespace. | 92 |
| '6' is a magic number. | 93 |
| Parameter g2d should be final. | 100 |
| '{' is not preceded with whitespace. | 100 |
| Variable 'center' should be declared final. | 101 |
| Variable 'graphPosition' should be declared final. | 102 |
| Variable 'zoom' should be declared final. | 103 |
| 'for' is not followed by whitespace. | 107 |
| '{' is not preceded with whitespace. | 107 |
| 'if' is not followed by whitespace. | 108 |
| '{' is not preceded with whitespace. | 108 |
| Variable 'positionDataString' should be declared final. | 109 |
| 'cast' is not followed by whitespace. | 109 |
| '10' is a magic number. | 110 |
| '18' is a magic number. | 110 |
| 'for' is not followed by whitespace. | 116 |
| '{' is not preceded with whitespace. | 116 |
| 'if' is not followed by whitespace. | 117 |
| '{' is not preceded with whitespace. | 117 |
| Variable 'positionDataString' should be declared final. | 118 |
| 'cast' is not followed by whitespace. | 118 |
| '10' is a magic number. | 119 |
| '18' is a magic number. | 119 |
| '{' is not preceded with whitespace. | 125 |
| Variable 'center' should be declared final. | 126 |
| Variable 'graphPosition' should be declared final. | 128 |
| Variable 'zoom' should be declared final. | 129 |
| 'for' is not followed by whitespace. | 133 |
| '{' is not preceded with whitespace. | 133 |
| 'if' is not followed by whitespace. | 134 |
| '{' is not preceded with whitespace. | 134 |
| 'for' is not followed by whitespace. | 142 |
| '{' is not preceded with whitespace. | 142 |
| 'if' is not followed by whitespace. | 143 |
| '{' is not preceded with whitespace. | 143 |
| Method 'setLog' is not designed for extension - needs to be abstract, final or empty. | 150 |
| Parameter log should be final. | 150 |
| method def child at indentation level 7 not at correct indentation, 8 | 151 |
| '{' is not preceded with whitespace. | 155 |
| 'if' is not followed by whitespace. | 157 |
| '{' is not preceded with whitespace. | 157 |
| 'if' is not followed by whitespace. | 160 |
| '64' is a magic number. | 160 |
| '{' is not preceded with whitespace. | 160 |
| 'if' is not followed by whitespace. | 162 |
| '32' is a magic number. | 162 |
| '{' is not preceded with whitespace. | 162 |
| 'if' is not followed by whitespace. | 164 |
| '16' is a magic number. | 164 |
| '{' is not preceded with whitespace. | 164 |
| '5' is a magic number. | 165 |
| 'if' is not followed by whitespace. | 166 |
| '8' is a magic number. | 166 |
| '{' is not preceded with whitespace. | 166 |
| '10' is a magic number. | 167 |
| 'if' is not followed by whitespace. | 168 |
| '4' is a magic number. | 168 |
| '{' is not preceded with whitespace. | 168 |
| '20' is a magic number. | 169 |
| 'if' is not followed by whitespace. | 170 |
| '{' is not preceded with whitespace. | 170 |
| '25' is a magic number. | 171 |
| 'if' is not followed by whitespace. | 172 |
| '{' is not preceded with whitespace. | 172 |
| '50' is a magic number. | 173 |
| '100' is a magic number. | 175 |
| Method 'getBestSnappingPosition' is not designed for extension - needs to be abstract, final or empty. | 179 |
| Parameter xMouseCoord should be final. | 179 |
| '{' is not preceded with whitespace. | 179 |
| 'if' is not followed by whitespace. | 181 |
| '{' is not preceded with whitespace. | 181 |
| Variable 'startPosition' should be declared final. | 185 |
| 'for' is not followed by whitespace. | 186 |
| '{' is not preceded with whitespace. | 186 |
| Variable 'next' should be declared final. | 187 |
| Variable 'prev' should be declared final. | 188 |
| 'if' is not followed by whitespace. | 189 |
| '{' is not preceded with whitespace. | 189 |
| 'if' is not followed by whitespace. | 192 |
| '{' is not preceded with whitespace. | 192 |
| 'if' is not followed by whitespace. | 195 |
| '{' is not preceded with whitespace. | 195 |
| Instance variable definition in wrong order. | 204 |
| Instance variable definition in wrong order. | 205 |
| Instance variable definition in wrong order. | 206 |
| Instance variable definition in wrong order. | 207 |
| Instance variable definition in wrong order. | 208 |
| Instance variable definition in wrong order. | 209 |
| Static variable definition in wrong order. | 210 |
| Violation | Message | Line |
|---|---|---|
| '-100' is a magic number. | 45 |
| '-100' is a magic number. | 46 |
| Executable statement count is 33 (max allowed is 30). | 51 |
| Method 'paint' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Parameter g should be final. | 52 |
| '1000' is a magic number. | 55 |
| '1000' is a magic number. | 60 |
| '0.001' is a magic number. | 60 |
| '20' is a magic number. | 71 |
| '20' is a magic number. | 71 |
| '20' is a magic number. | 74 |
| '20' is a magic number. | 74 |
| Variable 'd' should be declared final. | 76 |
| Variable 'center' should be declared final. | 77 |
| Variable 'multigGraph' should be declared final. | 78 |
| Variable 'g2d' should be declared final. | 79 |
| '30' is a magic number. | 80 |
| '60' is a magic number. | 80 |
| Variable 'snappedDataPosition' should be declared final. | 82 |
| Variable 'singleGraph' should be declared final. | 88 |
| Variable 'mouseDataString' should be declared final. | 90 |
| '15' is a magic number. | 91 |
| '8' is a magic number. | 91 |
| '15' is a magic number. | 91 |
| '15' is a magic number. | 93 |
| '15' is a magic number. | 93 |
| Method 'setLog' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Parameter log should be final. | 100 |
| Method 'mouseEntered' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Parameter e should be final. | 107 |
| Method 'mouseExited' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Parameter e should be final. | 112 |
| Method 'mouseMoved' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Parameter e should be final. | 118 |
| Parameter arg0 should be final. | 125 |
| Parameter e should be final. | 129 |
| Parameter e should be final. | 133 |
| Parameter e should be final. | 137 |
| Instance variable definition in wrong order. | 141 |
| Name 'FPScounter' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 141 |
| Variable 'FPScounter' explicitly initialized to '0' (default value for its type). | 141 |
| Variable 'FPScounter' must be private and have accessor methods. | 141 |
| Instance variable definition in wrong order. | 142 |
| Name 'FPS' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 142 |
| Variable 'FPS' explicitly initialized to '0' (default value for its type). | 142 |
| Variable 'FPS' must be private and have accessor methods. | 142 |
| Instance variable definition in wrong order. | 143 |
| Instance variable definition in wrong order. | 144 |
| Instance variable definition in wrong order. | 145 |
| Instance variable definition in wrong order. | 146 |
| '255' is a magic number. | 146 |
| '255' is a magic number. | 146 |
| '255' is a magic number. | 146 |
| '100' is a magic number. | 146 |
| Instance variable definition in wrong order. | 147 |
| '170' is a magic number. | 147 |
| Instance variable definition in wrong order. | 148 |
| Instance variable definition in wrong order. | 149 |
| Instance variable definition in wrong order. | 150 |
| Variable access definition in wrong order. | 150 |
| Variable 'mouseOver' must be private and have accessor methods. | 150 |
| Static variable definition in wrong order. | 151 |
| Violation | Message | Line |
|---|---|---|
| Static variable definition in wrong order. | 41 |
| '400' is a magic number. | 53 |
| '600' is a magic number. | 53 |
| '99' is a magic number. | 54 |
| Method 'addGraph' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Parameter header should be final. | 60 |
| Variable 'p' should be declared final. | 61 |
| Variable 'gl' should be declared final. | 68 |
| 'cast' is not followed by whitespace. | 68 |
| 'if' is not followed by whitespace. | 69 |
| '{' is not preceded with whitespace. | 69 |
| Variable 'graph' should be declared final. | 75 |
| ';' is not followed by whitespace. | 79 |
| Method 'removeGraph' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Parameter header should be final. | 89 |
| Variable 'temp' should be declared final. | 90 |
| Variable 't' should be declared final. | 93 |
| Control variable 'i' is modified. | 111 |
| Method 'setLog' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Parameter log should be final. | 117 |
| Method 'getInfoPanel' is not designed for extension - needs to be abstract, final or empty. | 124 |
| '{' is not preceded with whitespace. | 124 |
| Method 'setColor' is not designed for extension - needs to be abstract, final or empty. | 128 |
| Parameter header should be final. | 128 |
| Parameter newColor should be final. | 128 |
| Variable 'gl' should be declared final. | 131 |
| Method 'getTotalSplits' is not designed for extension - needs to be abstract, final or empty. | 138 |
| Method 'setTotalSplits' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Parameter totalSplits should be final. | 142 |
| 'totalSplits' hides a field. | 142 |
| Variable 'gl' should be declared final. | 147 |
| Violation | Message | Line |
|---|---|---|
| ',' is not followed by whitespace. | 48 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 51 |
| Declaring variables, return values or parameters of type 'LinkedList' is not allowed. | 52 |
| Declaring variables, return values or parameters of type 'LinkedList' is not allowed. | 53 |
| Static variable definition in wrong order. | 54 |
| Static variable definition in wrong order. | 55 |
| Parameter e should be final. | 66 |
| Method 'ancestorResized' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Parameter e should be final. | 70 |
| Method 'propertyChange' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Parameter evt should be final. | 77 |
| 'if' is not followed by whitespace. | 78 |
| '{' is not preceded with whitespace. | 78 |
| Method 'paint' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Parameter g should be final. | 86 |
| Cyclomatic Complexity is 13 (max allowed is 10). | 94 |
| Executable statement count is 40 (max allowed is 30). | 94 |
| NPath Complexity is 270 (max allowed is 200). | 94 |
| Parameter g should be final. | 94 |
| '{' is not preceded with whitespace. | 94 |
| Variable 'g2d' should be declared final. | 96 |
| Variable 'it' should be declared final. | 102 |
| 'if' is not followed by whitespace. | 106 |
| '{' is not preceded with whitespace. | 106 |
| 'if' is not followed by whitespace. | 110 |
| '{' is not preceded with whitespace. | 110 |
| Must have at least one statement. | 112 |
| 'if' is not followed by whitespace. | 116 |
| '{' is not preceded with whitespace. | 116 |
| Variable 'zoom' should be declared final. | 124 |
| Variable 'graphPosition' should be declared final. | 125 |
| Variable 'offset' should be declared final. | 126 |
| 'cast' is not followed by whitespace. | 127 |
| 'while' is not followed by whitespace. | 132 |
| '{' is not preceded with whitespace. | 132 |
| 'if' is not followed by whitespace. | 135 |
| '5' is a magic number. | 135 |
| '{' is not preceded with whitespace. | 135 |
| '4' is a magic number. | 136 |
| '4' is a magic number. | 136 |
| 'if' is not followed by whitespace. | 140 |
| '{' is not preceded with whitespace. | 140 |
| 'if' is not followed by whitespace. | 147 |
| '{' is not preceded with whitespace. | 147 |
| 'if' is not followed by whitespace. | 162 |
| '{' is not preceded with whitespace. | 162 |
| '5' is a magic number. | 165 |
| '4' is a magic number. | 166 |
| '4' is a magic number. | 166 |
| 'if' is not followed by whitespace. | 169 |
| '{' is not preceded with whitespace. | 169 |
| Cyclomatic Complexity is 14 (max allowed is 10). | 175 |
| Executable statement count is 40 (max allowed is 30). | 175 |
| NPath Complexity is 270 (max allowed is 200). | 175 |
| Parameter g should be final. | 175 |
| '{' is not preceded with whitespace. | 175 |
| Variable 'g2d' should be declared final. | 177 |
| Variable 'it' should be declared final. | 183 |
| 'if' is not followed by whitespace. | 187 |
| '{' is not preceded with whitespace. | 187 |
| 'if' is not followed by whitespace. | 191 |
| '{' is not preceded with whitespace. | 191 |
| Must have at least one statement. | 193 |
| 'if' is not followed by whitespace. | 197 |
| '{' is not preceded with whitespace. | 197 |
| Variable 'zoom' should be declared final. | 205 |
| Variable 'graphPosition' should be declared final. | 206 |
| Variable 'offset' should be declared final. | 207 |
| 'cast' is not followed by whitespace. | 208 |
| 'while' is not followed by whitespace. | 213 |
| '{' is not preceded with whitespace. | 213 |
| 'if' is not followed by whitespace. | 216 |
| '5' is a magic number. | 216 |
| '{' is not preceded with whitespace. | 216 |
| '4' is a magic number. | 217 |
| '4' is a magic number. | 217 |
| 'if' is not followed by whitespace. | 221 |
| '{' is not preceded with whitespace. | 221 |
| 'if' is not followed by whitespace. | 228 |
| '{' is not preceded with whitespace. | 228 |
| 'if' is not followed by whitespace. | 243 |
| '{' is not preceded with whitespace. | 243 |
| '5' is a magic number. | 246 |
| '4' is a magic number. | 247 |
| '4' is a magic number. | 247 |
| 'if' is not followed by whitespace. | 250 |
| '{' is not preceded with whitespace. | 250 |
| Parameter traceData should be final. | 256 |
| Parameter minValue should be final. | 256 |
| Parameter maxValue should be final. | 256 |
| Variable 'height' should be declared final. | 258 |
| 'cast' is not followed by whitespace. | 258 |
| '{' is not preceded with whitespace. | 265 |
| 'if' is not followed by whitespace. | 267 |
| '{' is not preceded with whitespace. | 267 |
| Method 'setData' is not designed for extension - needs to be abstract, final or empty. | 277 |
| Parameter GDE should be final. | 277 |
| 'GDE' hides a field. | 277 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 277 |
| Method 'getData' is not designed for extension - needs to be abstract, final or empty. | 282 |
| Method 'getMouseInfo' is not designed for extension - needs to be abstract, final or empty. | 291 |
| Parameter cursorDistanceFromCenter should be final. | 291 |
| Variable 'graphPosition' should be declared final. | 292 |
| Variable 'zoom' should be declared final. | 293 |
| Variable 'offset' should be declared final. | 294 |
| Assignment of parameter 'cursorDistanceFromCenter' is not allowed. | 295 |
| 'cast' is not followed by whitespace. | 295 |
| 'cast' is not followed by whitespace. | 296 |
| 'cast' is not followed by whitespace. | 296 |
| Variable 'cursorPosition' should be declared final. | 298 |
| 'cast' is not followed by whitespace. | 298 |
| 'cast' is not followed by whitespace. | 298 |
| Method 'getColor' is not designed for extension - needs to be abstract, final or empty. | 309 |
| Method 'setColor' is not designed for extension - needs to be abstract, final or empty. | 316 |
| Parameter c should be final. | 316 |
| Method 'initGraph' is not designed for extension - needs to be abstract, final or empty. | 323 |
| Variable 'graphPosition' should be declared final. | 327 |
| 'cast' is not followed by whitespace. | 327 |
| Variable 'zoom' should be declared final. | 328 |
| '6' is a magic number. | 330 |
| Variable 'halfNumPoints' should be declared final. | 331 |
| Variable 'leftGraphPosition' should be declared final. | 332 |
| Variable 'rightGraphPosition' should be declared final. | 333 |
| 'for' is not followed by whitespace. | 334 |
| '{' is not preceded with whitespace. | 334 |
| 'if' is not followed by whitespace. | 335 |
| '{' is not preceded with whitespace. | 335 |
| 'for' is not followed by whitespace. | 339 |
| '{' is not preceded with whitespace. | 339 |
| '{' is not preceded with whitespace. | 340 |
| Method 'sizeGraph' is not designed for extension - needs to be abstract, final or empty. | 349 |
| Variable 'lg' should be declared final. | 350 |
| ';' is preceded with whitespace. | 351 |
| Method 'graphSize' is not designed for extension - needs to be abstract, final or empty. | 368 |
| Violation | Message | Line |
|---|---|---|
| Class Data Abstraction Coupling is 11 (max allowed is 7) classes [ActionListener, ActiveHeaderLabel, ArrayList, ContainerListener, Dimension, JButton, JLayeredPane, JPanel, JScrollPane, ModifyGraphPane, MouseMotionAdapter]. | 61 |
| Declaring variables, return values or parameters of type 'ArrayList' is not allowed. | 70 |
| Static variable definition in wrong order. | 72 |
| Static variable definition in wrong order. | 73 |
| Static variable definition in wrong order. | 74 |
| Static variable definition in wrong order. | 76 |
| Static variable definition in wrong order. | 77 |
| Static variable definition in wrong order. | 78 |
| Static variable definition in wrong order. | 80 |
| Static variable definition in wrong order. | 81 |
| Static variable definition in wrong order. | 82 |
| ';' is not followed by whitespace. | 82 |
| Static variable definition in wrong order. | 83 |
| Static variable definition in wrong order. | 84 |
| ';' is not followed by whitespace. | 84 |
| Static variable definition in wrong order. | 85 |
| ';' is not followed by whitespace. | 85 |
| Static variable definition in wrong order. | 86 |
| Static variable definition in wrong order. | 89 |
| Static variable definition in wrong order. | 90 |
| Variable 'scroll' should be declared final. | 105 |
| Variable 'ih' should be declared final. | 118 |
| '1280' is a magic number. | 125 |
| Instance variable definition in wrong order. | 128 |
| Parameter e should be final. | 131 |
| Instance variable definition in wrong order. | 135 |
| Parameter e should be final. | 138 |
| Instance variable definition in wrong order. | 142 |
| Anonymous inner class length is 31 lines (max allowed is 20). | 142 |
| Parameter e should be final. | 145 |
| Parameter e should be final. | 159 |
| Variable 'row' should be declared final. | 178 |
| Variable 'col' should be declared final. | 179 |
| Variable 'activePanel' should be declared final. | 180 |
| Variable 'removeButton' should be declared final. | 191 |
| Cyclomatic Complexity is 12 (max allowed is 10). | 203 |
| Parameter e should be final. | 203 |
| Variable 'panel' should be declared final. | 204 |
| Name 'GCB' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 209 |
| Variable 'GCB' should be declared final. | 209 |
| ';' is not followed by whitespace. | 214 |
| Control variable 'i' is modified. | 216 |
| Variable 'row' should be declared final. | 222 |
| Variable 'col' should be declared final. | 223 |
| Variable 'active' should be declared final. | 232 |
| 'if' construct must use '{}'s. | 242 |
| 'if' is not followed by whitespace. | 242 |
| Instance variable definition in wrong order. | 245 |
| Anonymous inner class length is 27 lines (max allowed is 20). | 245 |
| Parameter e should be final. | 248 |
| Variable 'c' should be declared final. | 249 |
| Name 'GCB' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 250 |
| Variable 'GCB' should be declared final. | 250 |
| '16' is a magic number. | 252 |
| '{' is not followed by whitespace. | 252 |
| Variable 'cn' should be declared final. | 254 |
| Variable 'j' should be declared final. | 256 |
| Nested if-else depth is 3 (max allowed is 2). | 257 |
| ';' is not followed by whitespace. | 258 |
| '(' is followed by whitespace. | 259 |
| Parameter GCB should be final. | 273 |
| Name 'GCB' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 273 |
| Variable 'x' should be declared final. | 274 |
| Executable statement count is 36 (max allowed is 30). | 286 |
| Method 'updateFromLog' is not designed for extension - needs to be abstract, final or empty. | 286 |
| Parameter gl should be final. | 286 |
| Declaring variables, return values or parameters of type 'ArrayList' is not allowed. | 303 |
| Variable 'tmpList' should be declared final. | 303 |
| Variable 'i' should be declared final. | 304 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 310 |
| Variable 'GDE' should be declared final. | 310 |
| ';' is not followed by whitespace. | 316 |
| Parameter GCB should be final. | 344 |
| Name 'GCB' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 344 |
| Parameter GDE should be final. | 344 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 344 |
| Type Javadoc comment is missing an null tag. | 360 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 362 |
| Variable 'GDE' must be private and have accessor methods. | 362 |
| Name 'AHL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 363 |
| Variable 'AHL' must be private and have accessor methods. | 363 |
| Parameter e should be final. | 375 |
| Parameter e should be final. | 386 |
| Parameter e should be final. | 395 |
| Parameter e should be final. | 405 |
| Variable 'c' should be declared final. | 406 |
| Executable statement count is 34 (max allowed is 30). | 416 |
| '10' is a magic number. | 420 |
| '10' is a magic number. | 421 |
| '100' is a magic number. | 437 |
| '20' is a magic number. | 438 |
| '100' is a magic number. | 439 |
| '20' is a magic number. | 439 |
| '40' is a magic number. | 440 |
| '60' is a magic number. | 441 |
| '100' is a magic number. | 442 |
| '60' is a magic number. | 442 |
| '80' is a magic number. | 443 |
| '500' is a magic number. | 456 |
| '180' is a magic number. | 456 |
| '210' is a magic number. | 456 |
| '133' is a magic number. | 456 |
| Parameter gde should be final. | 462 |
| Parameter ahl should be final. | 462 |
| Catching 'Exception' is not allowed. | 474 |
| Must have at least one statement. | 474 |
| Catching 'Exception' is not allowed. | 479 |
| Must have at least one statement. | 479 |
| Type Javadoc comment is missing an null tag. | 489 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 491 |
| Anonymous inner class length is 59 lines (max allowed is 20). | 497 |
| Parameter e should be final. | 500 |
| '16' is a magic number. | 501 |
| '18' is a magic number. | 503 |
| Parameter e should be final. | 514 |
| Parameter e should be final. | 518 |
| Parameter e should be final. | 522 |
| Name 'GCB' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 523 |
| Variable 'GCB' should be declared final. | 523 |
| Parameter e should be final. | 528 |
| Name 'GCB' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 529 |
| Variable 'GCB' should be declared final. | 529 |
| Parameter x should be final. | 570 |
| Parameter y should be final. | 570 |
| Parameter widht should be final. | 570 |
| Parameter height should be final. | 570 |
| Parameter GDE should be final. | 577 |
| 'GDE' hides a field. | 577 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 577 |
| Parameter e should be final. | 585 |
| method call child at indentation level 12 not at correct indentation, 16 | 592 |
| Parameter previousPanel should be final. | 606 |
| 'previousPanel' hides a field. | 606 |
| Parameter dragging should be final. | 622 |
| 'dragging' hides a field. | 622 |
| Parameter selected should be final. | 626 |
| 'selected' hides a field. | 626 |
| Parameter o should be final. | 649 |
| Name 'GCB' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 651 |
| Variable 'GCB' should be declared final. | 651 |
| Violation | Message | Line |
|---|---|---|
| '{' is not preceded with whitespace. | 32 |
| '{' should be on the previous line. | 35 |
| Method 'addElement' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Parameter element should be final. | 41 |
| '{' should be on the previous line. | 42 |
| Method 'insertElementAt' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Parameter element should be final. | 48 |
| Parameter index should be final. | 48 |
| '{' should be on the previous line. | 49 |
| Variable 'size' should be declared final. | 50 |
| Assignment of parameter 'index' is not allowed. | 51 |
| Assignment of parameter 'index' is not allowed. | 51 |
| '{' should be on the previous line. | 52 |
| for child at indentation level 16 not at correct indentation, 12 | 53 |
| Variable 'c' should be declared final. | 53 |
| 'cast' is not followed by whitespace. | 53 |
| '(' is followed by whitespace. | 53 |
| ')' is preceded with whitespace. | 53 |
| 'if' construct must use '{}'s. | 54 |
| if at indentation level 16 not at correct indentation, 12 | 54 |
| Violation | Message | Line |
|---|---|---|
| Class Data Abstraction Coupling is 19 (max allowed is 7) classes [ActionListener, ArrayList, BorderLayout, BufferedWriter, Color, Dimension, File, FileReader, FileWriter, FlowLayout, JButton, JMenu, JMenuBar, JMenuItem, JPanel, JScrollPane, PropertyPanel, Scanner, SingleProperty]. | 63 |
| Class Fan-Out Complexity is 23 (max allowed is 20). | 63 |
| Name 'OLVProperties' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 67 |
| Variable 'OLVProperties' must be private and have accessor methods. | 67 |
| Declaring variables, return values or parameters of type 'ArrayList' is not allowed. | 68 |
| Variable 'properties' must be private and have accessor methods. | 68 |
| Declaring variables, return values or parameters of type 'ArrayList' is not allowed. | 69 |
| Variable 'removeProperties' must be private and have accessor methods. | 69 |
| Variable 'propertyPanel' must be private and have accessor methods. | 70 |
| Variable 'propertyView' must be private and have accessor methods. | 71 |
| Parameter title should be final. | 73 |
| Redundant throws: 'HeadlessException' is unchecked exception. | 73 |
| '350' is a magic number. | 76 |
| '500' is a magic number. | 76 |
| '550' is a magic number. | 77 |
| '500' is a magic number. | 77 |
| '400' is a magic number. | 86 |
| Variable 'jsp' should be declared final. | 89 |
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. | 95 |
| Declaring variables, return values or parameters of type 'ArrayList' is not allowed. | 95 |
| Parameter p should be final. | 95 |
| Variable 'systemDelim' should be declared final. | 103 |
| Variable 'homeDir' should be declared final. | 104 |
| The String ".OpenLogViewer" appears 3 times in the file. | 110 |
| The String "OLVProperties.olv" appears 2 times in the file. | 115 |
| Must have at least one statement. | 119 |
| Name 'IOE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 122 |
| Catching 'Exception' is not allowed. | 129 |
| Name 'E' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 129 |
| Variable 'propMenuBar' should be declared final. | 135 |
| Variable 'optionMenu' should be declared final. | 137 |
| Variable 'addProp' should be declared final. | 139 |
| Variable 'remProp' should be declared final. | 140 |
| Parameter evt should be final. | 145 |
| Variable 's' should be declared final. | 146 |
| 'if' is not followed by whitespace. | 147 |
| String literal expressions should be on the left side of an equals comparison. | 147 |
| '{' is not preceded with whitespace. | 147 |
| if child at indentation level 16 not at correct indentation, 20 | 148 |
| Variable 'newprop' should be declared final. | 148 |
| if child at indentation level 16 not at correct indentation, 20 | 149 |
| method call child at indentation level 16 not at correct indentation, 20 | 149 |
| if child at indentation level 16 not at correct indentation, 20 | 150 |
| method call child at indentation level 16 not at correct indentation, 20 | 150 |
| Parameter evt should be final. | 158 |
| Variable 'aPanel' should be declared final. | 171 |
| '500' is a magic number. | 172 |
| '32' is a magic number. | 172 |
| Variable 'okButton' should be declared final. | 175 |
| Variable 'cancel' should be declared final. | 176 |
| Parameter e should be final. | 181 |
| Parameter e should be final. | 189 |
| Variable 'scan' should be declared final. | 204 |
| Variable 'propLine' should be declared final. | 207 |
| Variable 'sp' should be declared final. | 208 |
| Variable 'prop' should be declared final. | 209 |
| '3' is a magic number. | 215 |
| '4' is a magic number. | 216 |
| '5' is a magic number. | 217 |
| '6' is a magic number. | 218 |
| Name 'FNF' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 223 |
| Method 'save' is not designed for extension - needs to be abstract, final or empty. | 228 |
| Variable 'fstream' should be declared final. | 232 |
| Variable 'out' should be declared final. | 233 |
| Catching 'Exception' is not allowed. | 240 |
| '{' is not followed by whitespace. | 240 |
| Variable 'pp' should be declared final. | 247 |
| Method 'resetProperties' is not designed for extension - needs to be abstract, final or empty. | 252 |
| Variable 'pp' should be declared final. | 254 |
| Parameter sp should be final. | 265 |
| Variable 'pp' should be declared final. | 268 |
| Method 'addProperty' is not designed for extension - needs to be abstract, final or empty. | 276 |
| Parameter sp should be final. | 276 |
| Variable 'pp' should be declared final. | 277 |
| '60' is a magic number. | 282 |
| 'for' is not followed by whitespace. | 285 |
| '{' is not preceded with whitespace. | 285 |
| 'if' is not followed by whitespace. | 286 |
| '{' is not preceded with whitespace. | 286 |
| Method 'addPropertyAndSave' is not designed for extension - needs to be abstract, final or empty. | 296 |
| Parameter sp should be final. | 296 |
| Parameter sp should be final. | 301 |
| Variable 'pp' should be declared final. | 309 |
| ';' is not followed by whitespace. | 314 |
| '60' is a magic number. | 316 |
| Control variable 'i' is modified. | 320 |
| Type Javadoc comment is missing an null tag. | 326 |
| Class Data Abstraction Coupling is 8 (max allowed is 7) classes [Dimension, FlowLayout, JCheckBox, JComboBox, JLabel, JPanel, JTextField, MouseListener]. | 326 |
| Variable 'sp' must be private and have accessor methods. | 328 |
| Variable 'check' must be private and have accessor methods. | 329 |
| Variable 'colorBox' must be private and have accessor methods. | 330 |
| Variable 'minBox' must be private and have accessor methods. | 331 |
| Variable 'maxBox' must be private and have accessor methods. | 332 |
| Variable 'splitBox' must be private and have accessor methods. | 333 |
| Variable 'activeBox' must be private and have accessor methods. | 334 |
| Executable statement count is 39 (max allowed is 30). | 336 |
| Parameter sp should be final. | 336 |
| 'sp' hides a field. | 336 |
| '10' is a magic number. | 339 |
| '500' is a magic number. | 341 |
| '50' is a magic number. | 341 |
| Variable 'minLabel' should be declared final. | 342 |
| Variable 'maxLabel' should be declared final. | 343 |
| Variable 'colorLabel' should be declared final. | 344 |
| Variable 'splitLabel' should be declared final. | 345 |
| Variable 'activeLabel' should be declared final. | 346 |
| '15' is a magic number. | 348 |
| '20' is a magic number. | 348 |
| '50' is a magic number. | 351 |
| '20' is a magic number. | 351 |
| '50' is a magic number. | 354 |
| '20' is a magic number. | 354 |
| '30' is a magic number. | 358 |
| '20' is a magic number. | 358 |
| Variable 'tf' should be declared final. | 359 |
| '60' is a magic number. | 364 |
| '20' is a magic number. | 364 |
| Anonymous inner class length is 29 lines (max allowed is 20). | 367 |
| Parameter e should be final. | 370 |
| Variable 'newColor' should be declared final. | 371 |
| Parameter e should be final. | 381 |
| Parameter e should be final. | 385 |
| Parameter e should be final. | 389 |
| Parameter e should be final. | 393 |
| Parameter check should be final. | 413 |
| 'check' hides a field. | 413 |
| Parameter sp should be final. | 421 |
| 'sp' hides a field. | 421 |
| Variable 'active' should be declared final. | 430 |
| Parameter o should be final. | 443 |
| Variable 'pp' should be declared final. | 445 |
| Violation | Message | Line |
|---|---|---|
| Parameter GDE should be final. | 50 |
| Name 'GDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 50 |
| Method 'getColor' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Method 'setColor' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Parameter color should be final. | 63 |
| 'color' hides a field. | 63 |
| Method 'getHeader' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Method 'setHeader' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Parameter header should be final. | 71 |
| 'header' hides a field. | 71 |
| Method 'getMax' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Method 'setMax' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Parameter max should be final. | 79 |
| 'max' hides a field. | 79 |
| Method 'getMin' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Method 'setMin' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Parameter min should be final. | 87 |
| 'min' hides a field. | 87 |
| Method 'getSplit' is not designed for extension - needs to be abstract, final or empty. | 91 |
| Method 'setSplit' is not designed for extension - needs to be abstract, final or empty. | 95 |
| Parameter split should be final. | 95 |
| 'split' hides a field. | 95 |
| 'if' is not followed by whitespace. | 96 |
| '{' is not preceded with whitespace. | 96 |
| Assignment of parameter 'split' is not allowed. | 97 |
| Method 'isActive' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Method 'setActive' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Parameter active should be final. | 106 |
| 'active' hides a field. | 106 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 110 |
| The String "," appears 6 times in the file. | 113 |
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. | 121 |
| Parameter o should be final. | 121 |
| Variable 'sp' should be declared final. | 123 |
| Definition of 'equals()' without corresponding definition of 'hashCode()'. | 130 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 130 |
| covariant equals without overriding equals(java.lang.Object). | 130 |
| Parameter header should be final. | 130 |
| 'header' hides a field. | 130 |
