The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.diyefi.openlogviewer.OpenLogViewer.openAppWideProps(Properties) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 420 | Medium |
| Method org.diyefi.openlogviewer.OpenLogViewer.removeApplicationWideProperty(String) may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 383 | Medium |
| Method org.diyefi.openlogviewer.OpenLogViewer.saveApplicationWideProperty(String, String) may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 367 | Medium |
| org.diyefi.openlogviewer.OpenLogViewer.openAppWideProps(Properties) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 408 | Medium |
| org.diyefi.openlogviewer.OpenLogViewer.removeApplicationWideProperty(String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 383 | Medium |
| org.diyefi.openlogviewer.OpenLogViewer.saveApplicationWideProperty(String, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 367 | Medium |
| org.diyefi.openlogviewer.decoder.CSVTypeLog stored into non-transient field OpenLogViewer.decoderInUse | BAD_PRACTICE | SE_BAD_FIELD_STORE | 334 | Medium |
| org.diyefi.openlogviewer.decoder.FreeEMSBin stored into non-transient field OpenLogViewer.decoderInUse | BAD_PRACTICE | SE_BAD_FIELD_STORE | 332 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| java.awt.Color is incompatible with expected argument type MarkedColor in org.diyefi.openlogviewer.coloring.InitialLineColoring.giveBackColor(Color) | CORRECTNESS | GC_UNRELATED_TYPES | 89 | High |
| java.awt.Color is incompatible with expected argument type MarkedColor in org.diyefi.openlogviewer.coloring.InitialLineColoring.giveBackColor(Color) | CORRECTNESS | GC_UNRELATED_TYPES | 90 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.coloring.MarkedColor defines equals(MarkedColor) method and uses Object.equals(Object) | CORRECTNESS | EQ_SELF_USE_OBJECT | 91 | Medium |
| org.diyefi.openlogviewer.coloring.MarkedColor defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 91 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to splitLine in org.diyefi.openlogviewer.decoder.CSVTypeLog.decodeLog() | STYLE | DLS_DEAD_LOCAL_STORE | 81 | Medium |
| Dead store to split in org.diyefi.openlogviewer.decoder.CSVTypeLog.scanForDelimiter() | STYLE | DLS_DEAD_LOCAL_STORE | 121 | Medium |
| new org.diyefi.openlogviewer.decoder.CSVTypeLog(File) invokes Thread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 47 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.diyefi.openlogviewer.decoder.FreeEMSBin.run() | STYLE | REC_CATCH_EXCEPTION | 312 | Medium |
| new org.diyefi.openlogviewer.decoder.FreeEMSBin(File) invokes Thread.start() | MT_CORRECTNESS | SC_START_IN_CTOR | 215 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.decoder.FreeEmsPacket.getPayload() may expose internal representation by returning FreeEmsPacket.payload | MALICIOUS_CODE | EI_EXPOSE_REP | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.decoder.LogField.getBitFieldNames() may expose internal representation by returning LogField.bitFieldNames | MALICIOUS_CODE | EI_EXPOSE_REP | 104 | Medium |
| new org.diyefi.openlogviewer.decoder.LogField(String, LogField$types, String[]) may expose internal representation by storing an externally mutable object into LogField.bitFieldNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 78 | Medium |
| org.diyefi.openlogviewer.decoder.LogField.setBitFieldNames(String[]) may expose internal representation by storing an externally mutable object into LogField.bitFieldNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 119 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name org.diyefi.openlogviewer.decoder.LogField$types doesn't start with an upper case letter | BAD_PRACTICE | NM_CLASS_NAMING_CONVENTION | 4-22 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.genericlog.GenericDataElement.getTransferDataFlavors() may expose internal representation by returning GenericDataElement.dataFlavor | MALICIOUS_CODE | EI_EXPOSE_REP | 193 | Medium |
| org.diyefi.openlogviewer.genericlog.GenericDataElement defines compareTo(GenericDataElement) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 175 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.genericlog.GenericLog$1 stored into non-transient field GenericLog.autoLoad | BAD_PRACTICE | SE_BAD_FIELD_STORE | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| integral division result cast to double or float in org.diyefi.openlogviewer.graphing.EntireGraphingPanel.centerGraphPosition(int, int) | STYLE | ICAST_IDIV_CAST_TO_DOUBLE | 378 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$1 stored into non-transient field OptionFrameV2.addDivisionListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 123 | Medium |
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$3 stored into non-transient field OptionFrameV2.addRemoveListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 137 | Medium |
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$4 stored into non-transient field OptionFrameV2.labelAdapter | BAD_PRACTICE | SE_BAD_FIELD_STORE | 244 | Medium |
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$2 stored into non-transient field OptionFrameV2.remDivisionListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 130 | Medium |
| Method org.diyefi.openlogviewer.optionpanel.OptionFrameV2.updateFromLog(GenericLog) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 312 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$ActiveHeaderLabel defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 659-663 | Medium |
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$ActiveHeaderLabel$1 stored into non-transient field OptionFrameV2$ActiveHeaderLabel.selectedListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 500 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$ModifyGraphPane$2 stored into non-transient field OptionFrameV2$ModifyGraphPane.applyButtonListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 385 | Medium |
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$ModifyGraphPane$4 stored into non-transient field OptionFrameV2$ModifyGraphPane.colorButtonListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 405 | Medium |
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$ModifyGraphPane$1 stored into non-transient field OptionFrameV2$ModifyGraphPane.resetButtonListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 374 | Medium |
| org.diyefi.openlogviewer.optionpanel.OptionFrameV2$ModifyGraphPane$3 stored into non-transient field OptionFrameV2$ModifyGraphPane.saveButtonListener | BAD_PRACTICE | SE_BAD_FIELD_STORE | 394 | Medium |
| Should org.diyefi.openlogviewer.optionpanel.OptionFrameV2$ModifyGraphPane be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 360-488 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.diyefi.openlogviewer.propertypanel.PropertiesPane.loadProperties() may fail to clean up java.io.Reader | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 196 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.propertypanel.PropertiesPane$PropertyPanel defines compareTo(PropertiesPane$PropertyPanel) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 437 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diyefi.openlogviewer.propertypanel.SingleProperty defines compareTo(SingleProperty) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 122 | Medium |
